From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: [PATCH] git-gui: Make git-gui lib dir configurable at runtime
Date: Mon, 21 Jul 2014 17:57:44 -0400 [thread overview]
Message-ID: <1405979864.15933.4.camel@leckie> (raw)
In-Reply-To: <xmqqbnsiifq6.fsf@gitster.dls.corp.google.com>
On Mon, 2014-07-21 at 14:06 -0700, Junio C Hamano wrote:
> David Turner <dturner@twopensource.com> writes:
>
> > Introduce the GIT_GUI_LIB_DIR environment variable, to tell git-gui
> > where to look for TCL libs. This allows a git-gui which has been
> > built with a prefix of /foo to be run out of directory /bar. This is
> > the equivalent of GIT_EXEC_PATH or GITPERLLIB but for git-gui's TCL
> > libraries.
> >
> > Signed-off-by: David Turner <dturner@twitter.com>
> > ---
> > git-gui/Makefile | 3 ++-
> > git-gui/git-gui.sh | 6 +++++-
> > 2 files changed, 7 insertions(+), 2 deletions(-)
>
> Would a similar change to gitk necessary/beneficial to platforms
> that would benefit from this change?
Apparently not; it seems to work fine for me from an alternate location.
Convenient!
> git-gui directory in my tree comes from its upstream repository
> git://repo.or.cz/git-gui.git/, and it is maintained by Pat Thoyts
> (Cc'ed).
> Note that these two upstream projects do not have leading
> directories git-gui and gitk-git themselves (they are merged to my
> tree while their paths being renamed). A patch that is appliable to
> them would touch paths without them (e.g. Makefile and git-gui.sh
> for an equivalent of the patch I am responding to).
Pat, do you want patches via the git mailing list, personal mail, or
some other way?
next prev parent reply other threads:[~2014-07-21 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 18:20 [PATCH] git-gui: Make git-gui lib dir configurable at runtime David Turner
2014-07-21 21:06 ` Junio C Hamano
2014-07-21 21:57 ` David Turner [this message]
2014-08-10 12:03 ` Pat Thoyts
2014-08-12 16:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405979864.15933.4.camel@leckie \
--to=dturner@twopensource.com \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.