From: Arjun Sreedharan <arjun024@gmail.com>
To: rjw@rjwysocki.net
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] PNPACPI: check return value of pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data()
Date: Wed, 23 Jul 2014 00:43:39 +0530 [thread overview]
Message-ID: <1406056419-3047-1-git-send-email-arjun024@gmail.com> (raw)
Handle error condition since pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data() could return -EPERM.
Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
---
drivers/pnp/pnpacpi/core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
index b81448b..c3214e9 100644
--- a/drivers/pnp/pnpacpi/core.c
+++ b/drivers/pnp/pnpacpi/core.c
@@ -272,10 +272,14 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
strncpy(dev->name, acpi_device_bid(device), sizeof(dev->name));
if (dev->active)
- pnpacpi_parse_allocated_resource(dev);
+ error = pnpacpi_parse_allocated_resource(dev);
+ if (error)
+ return error;
if (dev->capabilities & PNP_CONFIGURABLE)
- pnpacpi_parse_resource_option_data(dev);
+ error = pnpacpi_parse_resource_option_data(dev);
+ if (error)
+ return error;
list_for_each_entry(id, &device->pnp.ids, list) {
if (!strcmp(id->id, pnpid))
--
1.7.11.7
next reply other threads:[~2014-07-22 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 19:13 Arjun Sreedharan [this message]
2014-07-22 22:12 ` [PATCH] PNPACPI: check return value of pnpacpi_parse_allocated_resource() and pnpacpi_parse_resource_option_data() Rafael J. Wysocki
2014-07-23 8:26 ` Arjun
2014-07-23 11:36 ` Rafael J. Wysocki
2014-07-23 19:49 ` Arjun Sreedharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406056419-3047-1-git-send-email-arjun024@gmail.com \
--to=arjun024@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.