From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from akt59.rev.netart.pl (akt59.rev.netart.pl [85.128.150.59]) by mail.openembedded.org (Postfix) with ESMTP id 4E90670789 for ; Wed, 23 Jul 2014 20:33:34 +0000 (UTC) Received: from localhost.localdomain (unknown [78.9.140.240]) by open-rnd.nazwa.pl (Postfix) with ESMTP id BC7273170048; Wed, 23 Jul 2014 22:33:34 +0200 (CEST) Message-ID: <1406147614.32507.1.camel@localhost.localdomain> From: Maciek Borzecki To: Tom Zanussi Date: Wed, 23 Jul 2014 22:33:34 +0200 In-Reply-To: <1406146879.6335.38.camel@empanada> References: <1406111837-4287-1-git-send-email-maciej.borzecki@open-rnd.pl> <1406146879.6335.38.camel@empanada> Organization: Open-RnD sp. z o.o. X-Mailer: Evolution 3.12.3 (3.12.3-1.fc20) Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] wic: squashfs partition support X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: maciej.borzecki@open-rnd.pl List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 20:33:36 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On śro, 2014-07-23 at 15:21 -0500, Tom Zanussi wrote: > Hi, please include a description for this. Ok, will update with the rest of the patches. > > Also, it looks like this is missing the empty_partition() part? That's intentional. Squashfs, being read-only, is not really useful for a partition that is empty. You wouldn't be able to create files nor actually use it in a meaningful manner, unless it's combined with one of the merging filesystems like {union/au/overlay}fs. In this case the whole fs setup would be described in fstab. Though, it might make sense to raise a warning at least. > > Thanks, > > Tom > > On Wed, 2014-07-23 at 12:37 +0200, Maciej Borzecki wrote: > > Signed-off-by: Maciej Borzecki > > --- > > .../lib/mic/kickstart/custom_commands/partition.py | 26 ++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/scripts/lib/mic/kickstart/custom_commands/partition.py b/scripts/lib/mic/kickstart/custom_commands/partition.py > > index d0f1b78..c4d0113 100644 > > --- a/scripts/lib/mic/kickstart/custom_commands/partition.py > > +++ b/scripts/lib/mic/kickstart/custom_commands/partition.py > > @@ -192,6 +192,10 @@ class Wic_PartData(Mic_PartData): > > return self.prepare_rootfs_vfat(cr_workdir, oe_builddir, > > rootfs_dir, native_sysroot, > > pseudo) > > + elif self.fstype.startswith("squashfs"): > > + return self.prepare_rootfs_squashfs(cr_workdir, oe_builddir, > > + rootfs_dir, native_sysroot, > > + pseudo) > > > > def prepare_rootfs_ext(self, cr_workdir, oe_builddir, rootfs_dir, > > native_sysroot, pseudo): > > @@ -324,6 +328,28 @@ class Wic_PartData(Mic_PartData): > > self.set_size(rootfs_size) > > self.set_source_file(rootfs) > > > > + def prepare_rootfs_squashfs(self, cr_workdir, oe_builddir, rootfs_dir, > > + native_sysroot, pseudo): > > + """ > > + Prepare content for a squashfs rootfs partition. > > + """ > > + image_rootfs = rootfs_dir > > + rootfs = "%s/rootfs_%s.%s" % (cr_workdir, self.label ,self.fstype) > > + > > + squashfs_cmd = "mksquashfs %s %s -noappend" % \ > > + (image_rootfs, rootfs) > > + rc, out = exec_native_cmd(pseudo + squashfs_cmd, native_sysroot) > > + > > + # get the rootfs size in the right units for kickstart (Mb) > > + du_cmd = "du -Lbms %s" % rootfs > > + rc, out = exec_cmd(du_cmd) > > + rootfs_size = out.split()[0] > > + > > + self.size = rootfs_size > > + self.source_file = rootfs > > + > > + return 0 > > + > > def prepare_empty_partition(self, cr_workdir, oe_builddir, native_sysroot): > > """ > > Prepare an empty partition. > > -- Maciej Borzęcki Senior Software Developer at Open-RnD Sp. z o.o., Poland www.open-rnd.pl mobile: +48 889 117 365, fax: +48 42 657 9079 Niniejsza wiadomość wraz z załącznikami może zawierać chronione prawem lub poufne informacje i została wysłana wyłącznie do wiadomości i użytku osób, do których została zaadresowana. Jeśli wiadomość została otrzymana przypadkowo zabrania się jej kopiowania lub rozsyłania do osób trzecich. W takim przypadku uprasza się o natychmiastowe zniszczenie wiadomości oraz poinformowanie nadawcy o zaistniałej sytuacji za pomocą wiadomości zwrotnej. Dziękujemy. This message, including any attachments hereto, may contain privileged or confidential information and is sent solely for the attention and use of the intended addressee(s). If you are not an intended addressee, you may neither use this message nor copy or deliver it to anyone. In such case, you should immediately destroy this message and kindly notify the sender by reply email. Thank you.