From: Philipp Zabel <philipp.zabel@gmail.com>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Kamil Debski <k.debski@samsung.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
kernel@pengutronix.de, Philipp Zabel <philipp.zabel@gmail.com>
Subject: [PATCH 1/3] [media] coda: fix coda_s_fmt_vid_out
Date: Sat, 26 Jul 2014 16:34:30 +0200 [thread overview]
Message-ID: <1406385272-425-1-git-send-email-philipp.zabel@gmail.com> (raw)
Set the context color space when s_fmt succeeded, not when it failed.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
drivers/media/platform/coda/coda-common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index dbd04ee..95d0b04 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -530,7 +530,9 @@ static int coda_s_fmt_vid_out(struct file *file, void *priv,
ret = coda_s_fmt(ctx, f);
if (ret)
- ctx->colorspace = f->fmt.pix.colorspace;
+ return ret;
+
+ ctx->colorspace = f->fmt.pix.colorspace;
return ret;
}
--
2.0.1
next reply other threads:[~2014-07-26 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 14:34 Philipp Zabel [this message]
2014-07-26 14:34 ` [PATCH 2/3] [media] coda: fix coda_g_selection Philipp Zabel
2014-07-26 15:12 ` Hans Verkuil
2014-07-26 16:37 ` Philipp Zabel
2014-07-26 17:08 ` Hans Verkuil
2014-07-27 16:53 ` Nicolas Dufresne
2014-07-27 18:21 ` Hans Verkuil
2014-07-27 21:32 ` Nicolas Dufresne
2014-07-27 22:22 ` Hans Verkuil
2014-07-28 9:28 ` Philipp Zabel
2014-07-26 14:34 ` [PATCH 3/3] [media] coda: set capture frame size with output S_FMT Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406385272-425-1-git-send-email-philipp.zabel@gmail.com \
--to=philipp.zabel@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=k.debski@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=nicolas.dufresne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.