From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 7F5F0E006EF; Sun, 27 Jul 2014 16:05:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (bisson.gary[at]gmail.com) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.44 listed in list.dnswl.org] Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id A11F4E004D9 for ; Sun, 27 Jul 2014 16:05:25 -0700 (PDT) Received: by mail-pa0-f44.google.com with SMTP id eu11so9377413pac.3 for ; Sun, 27 Jul 2014 16:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=libqF4zWfy/PDgKBo429NIiTHLrXISG1rdL1RXywXyI=; b=nqlthVWdquncIQ/SB3PFHyGfDjKxZfBvwEnOzijTFMcA3JfD7CciL7duAWU3fxdzFq MP4Tjb0DIHVgHynn4npDnQkx5Fm80f17ygKO6vbcyg/+X0r4hJFkYz5xr1Km3vlceO2Q PfhH8oXEGqMR6xC84b3CZdguDLFfPXeKkcZqIVgbBbAo6bPzXKoLjhrA6QAhDYodMM9o 5L6TjLUFUIwitMYVj0tnX3YlYUIytWj+3mIfJ3EDWIoVv0JQN2ipdRtOLit/OWtHxHSv bnhn1okwjKYH+crIvH+pa0TK5oNbCAeZyiM5PRYmwcZLYoAP4UHdMWOHk2tLw3Vp9kif DzaA== X-Received: by 10.70.50.137 with SMTP id c9mr34018386pdo.101.1406502325210; Sun, 27 Jul 2014 16:05:25 -0700 (PDT) Received: from n411z.WORKGROUP. (c-24-22-143-40.hsd1.wa.comcast.net. [24.22.143.40]) by mx.google.com with ESMTPSA id n3sm21251901pde.47.2014.07.27.16.05.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 27 Jul 2014 16:05:24 -0700 (PDT) From: Gary Bisson To: meta-freescale@yoctoproject.org Date: Sun, 27 Jul 2014 16:05:03 -0700 Message-Id: <1406502303-18653-1-git-send-email-bisson.gary@gmail.com> X-Mailer: git-send-email 2.0.1 Cc: Gary Bisson Subject: [meta-fsl-arm][PATCH] gst-fsl-plugin: fix build for kernel headers >= 3.10 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2014 23:05:31 -0000 This package couldn't build using a toolchain with kernel headers >= 3.10 because of the use of VIDIOC_DBG_G_CHIP_IDENT. As stated in videodev2.h, this ioctl should never be used. --- Hi all, It has been reported that this package couldn't be built using a recent toolchain such as CodeSourcery 2013.11 as its kernel headers are > 3.10. After looking at the source code it appears it comes from the use of VIDIOC_DBG_G_CHIP_IDENT ioctl. Also, nothing justifies the use of that obsolete ioctl. Its only purpose is to get the video device name so this patch actually removes those unnecessary calls. It'd be great to have those call removed on next package release. Thanks, Gary --- recipes-multimedia/gstreamer/gst-fsl-plugin.inc | 3 +- ...e-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch | 69 ++++++++++++++++++++++ 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc index dca9209..f8685bc 100644 --- a/recipes-multimedia/gstreamer/gst-fsl-plugin.inc +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin.inc @@ -19,7 +19,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ S = "${WORKDIR}/gst-fsl-plugins-${PV}" SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-${PV}.tar.gz \ - file://build-Fix-out-of-tree-build.patch" + file://build-Fix-out-of-tree-build.patch \ + file://Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch" inherit autotools pkgconfig diff --git a/recipes-multimedia/gstreamer/gst-fsl-plugin/Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch b/recipes-multimedia/gstreamer/gst-fsl-plugin/Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch new file mode 100644 index 0000000..5635275 --- /dev/null +++ b/recipes-multimedia/gstreamer/gst-fsl-plugin/Remove-use-of-obsolete-VIDIOC_DBG_G_CHIP_IDENT.patch @@ -0,0 +1,69 @@ +From ce90794a3458af0aed43b8570cf44cd87900185d Mon Sep 17 00:00:00 2001 +From: Gary Bisson +Date: Fri, 25 Jul 2014 16:44:53 -0700 +Subject: [PATCH] Remove use of obsolete VIDIOC_DBG_G_CHIP_IDENT + +This ioctl should never be used in application as +stated in videodev2.h header. +Moreover, its use in this plugin was very limited. + +Signed-off-by: Gary Bisson +--- + src/misc/tvsrc/src/mfw_gst_tvsrc.c | 8 -------- + src/misc/v4l_source/src/mfw_gst_v4lsrc.c | 7 ------- + 2 files changed, 15 deletions(-) + +diff --git a/src/misc/tvsrc/src/mfw_gst_tvsrc.c b/src/misc/tvsrc/src/mfw_gst_tvsrc.c +index 67e0cd2..f495b6f 100755 +--- a/src/misc/tvsrc/src/mfw_gst_tvsrc.c ++++ b/src/misc/tvsrc/src/mfw_gst_tvsrc.c +@@ -450,7 +450,6 @@ mfw_gst_tvsrc_capture_setup (MFWGstTVSRC * v4l_src) + struct v4l2_format fmt; + struct v4l2_control ctrl; + struct v4l2_streamparm parm; +- struct v4l2_dbg_chip_ident chip; + gint fd_v4l = 0; + struct v4l2_mxc_offset off; + gint in_width = 0, in_height = 0; +@@ -461,13 +460,6 @@ mfw_gst_tvsrc_capture_setup (MFWGstTVSRC * v4l_src) + return 0; + } + +- if (ioctl (fd_v4l, VIDIOC_DBG_G_CHIP_IDENT, &chip)) { +- g_print ("VIDIOC_DBG_G_CHIP_IDENT failed.\n"); +- } else +- g_print ("sensor chip is %s\n", chip.match.name); +- +- +- + if (ioctl (fd_v4l, VIDIOC_G_STD, &id) < 0) { + g_print ("VIDIOC_G_STD failed\n"); + close (fd_v4l); +diff --git a/src/misc/v4l_source/src/mfw_gst_v4lsrc.c b/src/misc/v4l_source/src/mfw_gst_v4lsrc.c +index 2c2e838..85e7ff0 100755 +--- a/src/misc/v4l_source/src/mfw_gst_v4lsrc.c ++++ b/src/misc/v4l_source/src/mfw_gst_v4lsrc.c +@@ -464,7 +464,6 @@ mfw_gst_v4lsrc_capture_setup (MFWGstV4LSrc * v4l_src) + struct v4l2_format fmt = {0}; + struct v4l2_control ctrl = {0}; + struct v4l2_streamparm parm = {0}; +- struct v4l2_dbg_chip_ident chip = {0}; + struct v4l2_frmsizeenum fszenum = {0}; + gint input; + gint fd_v4l = 0; +@@ -476,12 +475,6 @@ mfw_gst_v4lsrc_capture_setup (MFWGstV4LSrc * v4l_src) + return 0; + } + +- if (ioctl (fd_v4l, VIDIOC_DBG_G_CHIP_IDENT, &chip)) { +- GST_ERROR ("VIDIOC_DBG_G_CHIP_IDENT failed."); +- } else +- GST_INFO ("sensor chip is %s", chip.match.name); +- +- + if (v4l_src->crop_pixel) { + in_width = v4l_src->capture_width - (2 * v4l_src->crop_pixel); + in_height = v4l_src->capture_height - (2 * v4l_src->crop_pixel); +-- +2.0.1 + -- 2.0.1