From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lekensteyn Subject: Re: [PATCH] i915: initialize CADL in opregion Date: Wed, 27 Jun 2012 17:09:02 +0200 Message-ID: <1406538.9ve8iYH0Aa@al> References: <1574631.uSlQXEJRId@al> <20120626210755.GB5072@phenom.ffwll.local> <20120627150302.GE5326@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id F3634A096C for ; Wed, 27 Jun 2012 08:09:56 -0700 (PDT) Received: by eaaf11 with SMTP id f11so453645eaa.36 for ; Wed, 27 Jun 2012 08:09:55 -0700 (PDT) In-Reply-To: <20120627150302.GE5326@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wednesday 27 June 2012 17:03:02 Daniel Vetter wrote: > On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote: > > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote: > > > On Tue, 26 Jun 2012 00:36:24 +0200 > > > > > > Lekensteyn wrote: > > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. > > > > CADL is not used anywhere in the driver code at the moment, but it > > > > could be used in BIOS as is the case with the Clevo laptop. > > > > > > > > The Clevo B7130 requires the CADL field to contain at least the ID of > > > > the LCD device. If this field is empty, the ACPI methods that are > > > > called > > > > on pressing brightness / display switching hotkeys will not trigger a > > > > notification. As a result, it appears as no hotkey has been pressed. > > > > > > Not ideal, but definitely better than nothing. > > > > > > Acked-by: Jesse Barnes > > > > Queued for -next, thanks for the patch. > > Unfortunately this results in a neat black screen on my ivb zenbook. Until > I've figured out what exactly's going on, I have to drop this from -next > again. > -Daniel Can you share your acpidump on https://bugs.freedesktop.org/show_bug.cgi?id=45452 ? TIA Peter