From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC v2 1/4] xen: add real time scheduler rt Date: Tue, 29 Jul 2014 11:42:38 +0200 Message-ID: <1406626958.4038.33.camel@Solace> References: <1406598782-2237-1-git-send-email-mengxu@cis.upenn.edu> <1406598782-2237-2-git-send-email-mengxu@cis.upenn.edu> <53D760D8020000780002717F@mail.emea.novell.com> Reply-To: raistlin@linux.it Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0108300692739962231==" Return-path: In-Reply-To: <53D760D8020000780002717F@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, xumengpanda@gmail.com, Meng Xu , lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============0108300692739962231== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-VELdsqKXPjfJ9QJIkM+6" --=-VELdsqKXPjfJ9QJIkM+6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2014-07-29 at 07:52 +0100, Jan Beulich wrote: > >>> On 29.07.14 at 03:52, wrote: > > --- a/xen/include/public/domctl.h > > +++ b/xen/include/public/domctl.h > > @@ -339,6 +339,18 @@ struct xen_domctl_max_vcpus { > > typedef struct xen_domctl_max_vcpus xen_domctl_max_vcpus_t; > > DEFINE_XEN_GUEST_HANDLE(xen_domctl_max_vcpus_t); > > =20 > > +/* > > + * This structure is used to pass to rt scheduler from a=20 > > + * privileged domain to Xen > > + */ > > +struct xen_domctl_sched_rt_params { > > + /* get vcpus' info */ > > + int64_t period; /* s_time_t type */ > > + int64_t budget; > > + int index; >=20 > Are all these really meaningfully signed quantities? >=20 The scheduler internal variable where the actual budget is kept updated needs, IMO, to be signed (s_time_t is the best choice). However, as far as the interface is concerned, I think Jan is right, being able to specify a negative budget and period is not that useful! :-P I think you can go for unsigned quantities here, while s_time_t is certainly ok inside the scheduler. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-VELdsqKXPjfJ9QJIkM+6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlPXbI4ACgkQk4XaBE3IOsTBBwCfblXcw04Ya4UHDhixO5HfwEHA xugAn2LE+qRg5WfhmTfCj1SPYLzicUAT =sWrG -----END PGP SIGNATURE----- --=-VELdsqKXPjfJ9QJIkM+6-- --===============0108300692739962231== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0108300692739962231==--