All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Boll <andreas.boll.dev@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: [PATCH 3/4] drm/radeon: use packet3 for nop on hawaii with new firmware
Date: Fri,  1 Aug 2014 20:05:31 +0200	[thread overview]
Message-ID: <1406916332-4195-3-git-send-email-andreas.boll.dev@gmail.com> (raw)
In-Reply-To: <1406916332-4195-1-git-send-email-andreas.boll.dev@gmail.com>

From: Alex Deucher <alexander.deucher@amd.com>

Older firmware didn't support the new nop packet.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Andreas Boll <andreas.boll.dev@gmail.com>
---
 drivers/gpu/drm/radeon/cik.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
index e5985d5..8b580dc 100644
--- a/drivers/gpu/drm/radeon/cik.c
+++ b/drivers/gpu/drm/radeon/cik.c
@@ -8035,7 +8035,10 @@ static int cik_startup(struct radeon_device *rdev)
 	cik_irq_set(rdev);
 
 	if (rdev->family == CHIP_HAWAII) {
-		nop = RADEON_CP_PACKET2;
+		if (rdev->new_fw)
+			nop = PACKET3(PACKET3_NOP, 0x3FFF);
+		else
+			nop = RADEON_CP_PACKET2;
 	} else {
 		nop = PACKET3(PACKET3_NOP, 0x3FFF);
 	}
-- 
2.0.1

  parent reply	other threads:[~2014-08-01 18:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 18:05 [PATCH 1/4] drm/radeon: use packet2 for nop on hawaii with old firmware Andreas Boll
2014-08-01 18:05 ` [PATCH 2/4] drm/radeon: tweak ACCEL_WORKING2 query for hawaii Andreas Boll
2014-08-01 18:05 ` Andreas Boll [this message]
2014-08-01 18:05 ` [PATCH 4/4] drm/radeon: tweak ACCEL_WORKING2 query for the new firmware " Andreas Boll
2014-08-04 18:42 ` [PATCH 1/4] drm/radeon: use packet2 for nop on hawaii with old firmware Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406916332-4195-3-git-send-email-andreas.boll.dev@gmail.com \
    --to=andreas.boll.dev@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.