All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Musta <tommusta@gmail.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, riku.voipio@linaro.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH 06/12] linux-user: Detect Negative Message Sizes in msgsnd System Call
Date: Mon,  4 Aug 2014 11:45:33 -0500	[thread overview]
Message-ID: <1407170739-12237-7-git-send-email-tommusta@gmail.com> (raw)
In-Reply-To: <1407170739-12237-1-git-send-email-tommusta@gmail.com>

The msgsnd system call takes an argument that describes the message
size (msgsz) and is of type size_t.  The system call should set
errno to EINVAL in the event that a negative message size is passed.

Signed-off-by: Tom Musta <tommusta@gmail.com>

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index c0c0434..f524a39 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2870,12 +2870,16 @@ struct target_msgbuf {
 };
 
 static inline abi_long do_msgsnd(int msqid, abi_long msgp,
-                                 unsigned int msgsz, int msgflg)
+                                 ssize_t msgsz, int msgflg)
 {
     struct target_msgbuf *target_mb;
     struct msgbuf *host_mb;
     abi_long ret = 0;
 
+    if (msgsz < 0) {
+        return -TARGET_EINVAL;
+    }
+
     if (!lock_user_struct(VERIFY_READ, target_mb, msgp, 0))
         return -TARGET_EFAULT;
     host_mb = malloc(msgsz+sizeof(long));
-- 
1.7.1

  parent reply	other threads:[~2014-08-04 16:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 16:45 [Qemu-devel] [PATCH 00/12] target-ppc: Linux-User Mode Bug Fixes for Power Tom Musta
2014-08-04 16:45 ` [Qemu-devel] [PATCH 01/12] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2 Tom Musta
2014-08-04 16:45 ` [Qemu-devel] [PATCH 02/12] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call Tom Musta
2014-08-04 17:04   ` Peter Maydell
2014-08-04 18:21     ` Tom Musta
2014-08-04 16:45 ` [Qemu-devel] [PATCH 03/12] linux-user: Properly Handle semun Structure In Cross-Endian Situations Tom Musta
2014-08-04 17:23   ` Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 04/12] linux-user: Make ipc syscall's third argument an abi_long Tom Musta
2014-08-04 17:09   ` Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 05/12] linux-user: Conditionally Pass Attribute Pointer to mq_open() Tom Musta
2014-08-04 17:10   ` Peter Maydell
2014-08-04 16:45 ` Tom Musta [this message]
2014-08-04 17:26   ` [Qemu-devel] [PATCH 06/12] linux-user: Detect Negative Message Sizes in msgsnd System Call Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 07/12] linux-user: Handle NULL argument to sched_{get, set}param Tom Musta
2014-08-04 17:32   ` Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 08/12] linux-user: Detect fault in sched_rr_get_interval Tom Musta
2014-08-04 17:34   ` Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 09/12] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2 Tom Musta
2014-08-04 17:39   ` Peter Maydell
2014-08-12 15:57     ` Alexander Graf
2014-08-04 16:45 ` [Qemu-devel] [PATCH 10/12] linux-user: clock_nanosleep errno Handling on PPC Tom Musta
2014-08-04 17:42   ` Peter Maydell
2014-08-04 17:43   ` Peter Maydell
2014-08-04 18:17     ` Tom Musta
2014-08-04 16:45 ` [Qemu-devel] [PATCH 11/12] linux-user: Support target-to-host translation of mlockall argument Tom Musta
2014-08-04 17:19   ` Peter Maydell
2014-08-04 16:45 ` [Qemu-devel] [PATCH 12/12] linux-user: writev Partial Writes Tom Musta
2014-08-04 17:29   ` Peter Maydell
2014-08-12 14:54 ` [Qemu-devel] [PATCH 00/12] target-ppc: Linux-User Mode Bug Fixes for Power Riku Voipio
2014-08-12 15:23   ` Tom Musta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407170739-12237-7-git-send-email-tommusta@gmail.com \
    --to=tommusta@gmail.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.