From: Brian Norris <computersforpeace@gmail.com>
To: <linux-mtd@lists.infradead.org>
Cc: Marek Vasut <marex@denx.de>, Huang Shijie <b32955@freescale.com>,
Brian Norris <computersforpeace@gmail.com>,
zajec5@gmail.com
Subject: [PATCH 5/8] mtd: fsl-quadspi: drop wait-till-ready checks
Date: Wed, 6 Aug 2014 18:16:59 -0700 [thread overview]
Message-ID: <1407374222-8448-6-git-send-email-computersforpeace@gmail.com> (raw)
In-Reply-To: <1407374222-8448-1-git-send-email-computersforpeace@gmail.com>
spi-nor.c should be taking care of these now.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>
---
drivers/mtd/spi-nor/fsl-quadspi.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 8d659a2888d5..9c13622a0c7a 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -719,16 +719,10 @@ static int fsl_qspi_read(struct spi_nor *nor, loff_t from,
{
struct fsl_qspi *q = nor->priv;
u8 cmd = nor->read_opcode;
- int ret;
dev_dbg(q->dev, "cmd [%x],read from (0x%p, 0x%.8x, 0x%.8x),len:%d\n",
cmd, q->ahb_base, q->chip_base_addr, (unsigned int)from, len);
- /* Wait until the previous command is finished. */
- ret = nor->wait_till_ready(nor);
- if (ret)
- return ret;
-
/* Read out the data directly from the AHB buffer.*/
memcpy(buf, q->ahb_base + q->chip_base_addr + from, len);
@@ -744,11 +738,6 @@ static int fsl_qspi_erase(struct spi_nor *nor, loff_t offs)
dev_dbg(nor->dev, "%dKiB at 0x%08x:0x%08x\n",
nor->mtd->erasesize / 1024, q->chip_base_addr, (u32)offs);
- /* Wait until finished previous write command. */
- ret = nor->wait_till_ready(nor);
- if (ret)
- return ret;
-
/* Send write enable, then erase commands. */
ret = nor->write_reg(nor, SPINOR_OP_WREN, NULL, 0, 0);
if (ret)
--
1.9.1
next prev parent reply other threads:[~2014-08-07 1:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 1:16 [PATCH 0/8] mtd: spi-nor: refactor wait-till-ready Brian Norris
2014-08-07 1:16 ` [PATCH 1/8] mtd: spi-nor: eliminate duplicate spi_nor_wait_till_{, fsr}_ready() code Brian Norris
2014-08-07 14:23 ` Marek Vasut
2014-08-09 6:25 ` Huang Shijie
2014-08-11 17:59 ` Brian Norris
2014-09-10 7:26 ` [PATCH v2 1/10] " Brian Norris
2014-08-07 1:16 ` [PATCH 2/8] mtd: spi-nor: handle timeout errors in spi_nor_write() Brian Norris
2014-08-07 14:23 ` Marek Vasut
2014-08-09 7:37 ` Huang Shijie
2014-08-07 1:16 ` [PATCH 3/8] mtd: spi-nor: move "wait-till-ready" checks into erase/write functions Brian Norris
2014-08-07 14:24 ` Marek Vasut
2014-08-09 8:42 ` Huang Shijie
2014-08-11 18:23 ` Brian Norris
2014-08-12 1:37 ` Huang Shijie
2014-08-07 1:16 ` [PATCH 4/8] mtd: m25p80: drop wait-till-ready checks Brian Norris
2014-08-07 14:24 ` Marek Vasut
2014-08-07 1:16 ` Brian Norris [this message]
2014-08-07 14:24 ` [PATCH 5/8] mtd: fsl-quadspi: " Marek Vasut
2014-08-07 1:17 ` [PATCH 6/8] mtd: spi-nor: drop replaceable wait-till-ready function pointer Brian Norris
2014-08-07 14:25 ` Marek Vasut
2014-08-09 9:53 ` Huang Shijie
2014-08-11 18:43 ` Brian Norris
2014-08-12 1:16 ` Huang Shijie
2014-09-10 7:02 ` Brian Norris
2014-08-12 5:13 ` Rafał Miłecki
2014-08-12 5:14 ` Rafał Miłecki
2014-08-07 1:17 ` [PATCH 7/8] mtd: spi-nor: factor out write_enable() for erase commands Brian Norris
2014-08-07 14:25 ` Marek Vasut
2014-08-09 10:52 ` Huang Shijie
2014-08-11 18:48 ` Brian Norris
2014-08-12 0:59 ` Huang Shijie
2014-09-10 7:05 ` Brian Norris
2014-09-10 15:20 ` Huang Shijie
2014-09-10 7:47 ` Brian Norris
2014-09-10 16:12 ` Huang Shijie
2014-09-10 23:25 ` Brian Norris
2014-11-05 10:29 ` [PATCH v2] " Brian Norris
2014-11-06 3:39 ` Huang Shijie
2014-12-01 8:19 ` Brian Norris
2014-08-07 1:17 ` [RFC 8/8] debug: mtd: spi-nor: add BUG_ON() prints to check for !ready Brian Norris
2014-08-07 14:26 ` Marek Vasut
2014-11-05 10:10 ` [PATCH 0/8] mtd: spi-nor: refactor wait-till-ready Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407374222-8448-6-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.