From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] mfd: sec-core: add missing sec_irq_init() return value checking Date: Fri, 08 Aug 2014 09:34:06 +0200 Message-ID: <1407483246.21474.0.camel@AMDC1943> References: <2486284.NeLpWWu75g@amdc1032> <2156078.GxeZgK3rLH@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:41188 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbaHHHeF (ORCPT ); Fri, 8 Aug 2014 03:34:05 -0400 In-reply-to: <2156078.GxeZgK3rLH@amdc1032> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: Samuel Ortiz , Lee Jones , Sangbeom Kim , Kyungmin Park , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org On czw, 2014-08-07 at 18:48 +0200, Bartlomiej Zolnierkiewicz wrote: > [ added missing linux-samsung-soc ML, sorry for the noise ] > > On Thursday, August 07, 2014 06:44:18 PM Bartlomiej Zolnierkiewicz wrote: > > sec_irq_init() can fail if it encounters unknown device type or > > on regmap_add_irq_chip() error. Add missing sec_irq_init() return > > value checking to sec_pmic_probe(). > > > > Tested on Insignal's Exynos4412 based Origen board. > > > > Cc: Krzysztof Kozlowski > > Cc: Sangbeom Kim > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Acked-by: Kyungmin Park > > --- > > patch is against next-20140804 branch of linux-next kernel > > > > drivers/mfd/sec-core.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) Looks and works good (tested on board with S2MPS14). Reviewed-by: Krzysztof Kozlowski Tested-by: Krzysztof Kozlowski Best regards, Krzysztof > > > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > > index dba7e2b..f498867 100644 > > --- a/drivers/mfd/sec-core.c > > +++ b/drivers/mfd/sec-core.c > > @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c, > > if (pdata && pdata->cfg_pmic_irq) > > pdata->cfg_pmic_irq(); > > > > - sec_irq_init(sec_pmic); > > + ret = sec_irq_init(sec_pmic); > > + if (ret) > > + return ret; > > > > pm_runtime_set_active(sec_pmic->dev);