diff for duplicates of <1407517179.2044.13.camel@jarvis.lan> diff --git a/a/1.txt b/N1/1.txt index 735a962..a02038a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,14 +12,14 @@ On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote: > T [] e; > position p; > @@ -> e =@p NULL +> e ==@p NULL > > @ disable fld_to_ptr@ > expression e; > identifier f; > position r.p; > @@ -> * e.f =@p NULL +> * e.f ==@p NULL > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> @@ -41,7 +41,7 @@ On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote: > if(chan < 0 || chan >= MAX_CHANNEL) > return NULL; > -> - if( pHba->channel[chan].device = NULL){ +> - if( pHba->channel[chan].device == NULL){ > - printk(KERN_DEBUG"Adaptec I2O RAID: Trying to find device before they are allocated\n"); > - return NULL; > - } @@ -49,7 +49,7 @@ On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote: dpt_i2o is always weirdly fun, but I think, based on the message, this check is supposed to be -if( pHba->channel[chan].device[id] = NULL){ +if( pHba->channel[chan].device[id] == NULL){ Since device is an array of device pointers which are allocated by parsing data. diff --git a/a/content_digest b/N1/content_digest index a6c8533..116dd76 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01407321551-27479-2-git-send-email-Julia.Lawall@lip6.fr\0" "From\0James Bottomley <James.Bottomley@hansenpartnership.com>\0" "Subject\0Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array\0" - "Date\0Fri, 08 Aug 2014 16:59:39 +0000\0" + "Date\0Fri, 08 Aug 2014 09:59:39 -0700\0" "To\0Julia Lawall <Julia.Lawall@lip6.fr>\0" "Cc\0Adaptec OEM Raid Solutions <aacraid@adaptec.com>" kernel-janitors@vger.kernel.org @@ -25,14 +25,14 @@ "> T [] e;\n" "> position p;\n" "> @@\n" - "> e =@p NULL\n" + "> e ==@p NULL\n" "> \n" "> @ disable fld_to_ptr@\n" "> expression e;\n" "> identifier f;\n" "> position r.p;\n" "> @@\n" - "> * e.f =@p NULL\n" + "> * e.f ==@p NULL\n" "> // </smpl>\n" "> \n" "> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>\n" @@ -54,7 +54,7 @@ "> \tif(chan < 0 || chan >= MAX_CHANNEL)\n" "> \t\treturn NULL;\n" "> \t\n" - "> -\tif( pHba->channel[chan].device = NULL){\n" + "> -\tif( pHba->channel[chan].device == NULL){\n" "> -\t\tprintk(KERN_DEBUG\"Adaptec I2O RAID: Trying to find device before they are allocated\\n\");\n" "> -\t\treturn NULL;\n" "> -\t}\n" @@ -62,11 +62,11 @@ "dpt_i2o is always weirdly fun, but I think, based on the message, this\n" "check is supposed to be \n" "\n" - "if( pHba->channel[chan].device[id] = NULL){\n" + "if( pHba->channel[chan].device[id] == NULL){\n" "\n" "Since device is an array of device pointers which are allocated by\n" "parsing data.\n" "\n" James -9720b1acb957cfdcbdd38439d099f68042b60a7a7a451fb4b6d74d6e8b8f0bab +6ea7ca95c70e57d2643c4e255dc999b97021f9a2312c181b6d364716f056101d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.