diff for duplicates of <1407518045.1686.0.camel@HansenPartnership.com> diff --git a/a/1.txt b/N1/1.txt index f519eba..430358d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: > > > if(chan < 0 || chan >= MAX_CHANNEL) > > > return NULL; > > > -> > > - if( pHba->channel[chan].device = NULL){ +> > > - if( pHba->channel[chan].device == NULL){ > > > - printk(KERN_DEBUG"Adaptec I2O RAID: Trying to find device before they are allocated\n"); > > > - return NULL; > > > - } @@ -15,7 +15,7 @@ On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: > > dpt_i2o is always weirdly fun, but I think, based on the message, this > > check is supposed to be > > -> > if( pHba->channel[chan].device[id] = NULL){ +> > if( pHba->channel[chan].device[id] == NULL){ > > > > Since device is an array of device pointers which are allocated by > > parsing data. @@ -23,7 +23,7 @@ On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote: > That seems to be already checked immediately below: > > d = pHba->channel[chan].device[id]; -> if(!d || d->tid = 0) { +> if(!d || d->tid == 0) { > return NULL; Yes, I know, but no message is emitted. The message seems to be for a diff --git a/a/content_digest b/N1/content_digest index 6f234eb..b32d41a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\0alpine.DEB.2.10.1408081902400.2348@hadrien\0" "From\0James Bottomley <James.Bottomley@hansenpartnership.com>\0" "Subject\0Re: [PATCH 1/1] dpt_i2o: delete unnecessary null test on array\0" - "Date\0Fri, 08 Aug 2014 17:14:05 +0000\0" + "Date\0Fri, 08 Aug 2014 10:14:05 -0700\0" "To\0Julia Lawall <julia.lawall@lip6.fr>\0" "Cc\0Adaptec OEM Raid Solutions <aacraid@adaptec.com>" kernel-janitors@vger.kernel.org @@ -22,7 +22,7 @@ "> > > \tif(chan < 0 || chan >= MAX_CHANNEL)\n" "> > > \t\treturn NULL;\n" "> > >\n" - "> > > -\tif( pHba->channel[chan].device = NULL){\n" + "> > > -\tif( pHba->channel[chan].device == NULL){\n" "> > > -\t\tprintk(KERN_DEBUG\"Adaptec I2O RAID: Trying to find device before they are allocated\\n\");\n" "> > > -\t\treturn NULL;\n" "> > > -\t}\n" @@ -30,7 +30,7 @@ "> > dpt_i2o is always weirdly fun, but I think, based on the message, this\n" "> > check is supposed to be\n" "> >\n" - "> > if( pHba->channel[chan].device[id] = NULL){\n" + "> > if( pHba->channel[chan].device[id] == NULL){\n" "> >\n" "> > Since device is an array of device pointers which are allocated by\n" "> > parsing data.\n" @@ -38,7 +38,7 @@ "> That seems to be already checked immediately below:\n" "> \n" "> d = pHba->channel[chan].device[id];\n" - "> \tif(!d || d->tid = 0) {\n" + "> \tif(!d || d->tid == 0) {\n" "> return NULL;\n" "\n" "Yes, I know, but no message is emitted. The message seems to be for a\n" @@ -46,4 +46,4 @@ "\n" James -a029c9da8d78f79e0ecc4148d79f22ab99c22a6077bfa4612386edb205f76945 +377a4e50bc14fff19c0d8302549258ff6e11e5794b0e602bb60230c54009a4a9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.