From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Mon, 11 Aug 2014 08:51:01 +0000 Subject: Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint Message-Id: <1407747061.4508.75.camel@pasglop> List-Id: References: <1406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com> <53E87023.6080200@suse.de> In-Reply-To: <53E87023.6080200@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , paulus@samba.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: > > diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c > > index da86d9b..d95014e 100644 > > --- a/arch/powerpc/kvm/emulate.c > > +++ b/arch/powerpc/kvm/emulate.c > > This should be book3s_emulate.c. Any reason we can't make that 00dddd00 opcode as breakpoint common to all powerpc variants ? Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 95BDD1A0718 for ; Mon, 11 Aug 2014 18:51:16 +1000 (EST) Message-ID: <1407747061.4508.75.camel@pasglop> Subject: Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint From: Benjamin Herrenschmidt To: Alexander Graf Date: Mon, 11 Aug 2014 18:51:01 +1000 In-Reply-To: <53E87023.6080200@suse.de> References: <1406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com> <53E87023.6080200@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , paulus@samba.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: > > diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c > > index da86d9b..d95014e 100644 > > --- a/arch/powerpc/kvm/emulate.c > > +++ b/arch/powerpc/kvm/emulate.c > > This should be book3s_emulate.c. Any reason we can't make that 00dddd00 opcode as breakpoint common to all powerpc variants ? Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint Date: Mon, 11 Aug 2014 18:51:01 +1000 Message-ID: <1407747061.4508.75.camel@pasglop> References: <1406868643-26291-1-git-send-email-maddy@linux.vnet.ibm.com> <53E87023.6080200@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , paulus@samba.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf Return-path: In-Reply-To: <53E87023.6080200@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org T24gTW9uLCAyMDE0LTA4LTExIGF0IDA5OjI2ICswMjAwLCBBbGV4YW5kZXIgR3JhZiB3cm90ZToK PiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMva3ZtL2VtdWxhdGUuYyBiL2FyY2gvcG93ZXJw Yy9rdm0vZW11bGF0ZS5jCj4gPiBpbmRleCBkYTg2ZDliLi5kOTUwMTRlIDEwMDY0NAo+ID4gLS0t IGEvYXJjaC9wb3dlcnBjL2t2bS9lbXVsYXRlLmMKPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9rdm0v ZW11bGF0ZS5jCj4gCj4gVGhpcyBzaG91bGQgYmUgYm9vazNzX2VtdWxhdGUuYy4KCkFueSByZWFz b24gd2UgY2FuJ3QgbWFrZSB0aGF0IDAwZGRkZDAwIG9wY29kZSBhcyBicmVha3BvaW50IGNvbW1v biB0bwphbGwgcG93ZXJwYyB2YXJpYW50cyA/CgpDaGVlcnMsCkJlbi4KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBs aXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9y Zy9saXN0aW5mby9saW51eHBwYy1kZXY=