From: Dexuan Cui <decui@microsoft.com>
To: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, olaf@aepfle.de,
apw@canonical.com, jasowang@redhat.com
Cc: kys@microsoft.com, haiyangz@microsoft.com
Subject: [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y
Date: Mon, 11 Aug 2014 20:30:40 -0700 [thread overview]
Message-ID: <1407814240-4275-1-git-send-email-decui@microsoft.com> (raw)
hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver
like atkbd.c.
atkbd.c depends on libps2.c because it invokes ps2_command().
libps2.c depends on i8042.c because it invokes i8042_check_port_owner().
As a result, hyperv_keyboard actually depends on i8042.c.
For a Generation 2 Hyper-V VM (meaning no i8042 device emulated), if a Linux
VM (like Arch Linux) happens to configure CONFIG_SERIO_I8042=m rather than
=y, atkbd.ko can't load because i8042.ko can't load(due to no i8042 device
emulated) and finally hyperv_keyboard can't work and the user can't input:
https://bugs.archlinux.org/task/39820
(Ubuntu/RHEL/SUSE aren't affected since they use CONFIG_SERIO_I8042=y)
Decoupling the dependency between hyperv_keyboard and i8042 needs
non-trivial efforts and is hence a long term goal.
For now, let's make the dependency explicit so people can beware of this.
Thank Claudio for the initial reporting, investigation and suggesting the fix.
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Reported-by: Claudio Latini <claudio.latini@live.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/input/serio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
index bc2d474..3277bff 100644
--- a/drivers/input/serio/Kconfig
+++ b/drivers/input/serio/Kconfig
@@ -273,7 +273,7 @@ config SERIO_OLPC_APSP
config HYPERV_KEYBOARD
tristate "Microsoft Synthetic Keyboard driver"
- depends on HYPERV
+ depends on HYPERV && SERIO_I8042=y
default HYPERV
help
Select this option to enable the Hyper-V Keyboard driver.
--
1.9.1
next reply other threads:[~2014-08-12 2:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 3:30 Dexuan Cui [this message]
2014-08-12 3:21 ` [PATCH] Input: serio: make HYPERV_KEYBOARD depend on SERIO_I8042=y Greg KH
2014-08-12 3:21 ` Greg KH
2014-08-12 5:51 ` Dexuan Cui
2014-08-12 6:01 ` Greg KH
2014-08-12 6:01 ` Greg KH
2014-08-12 7:15 ` Dexuan Cui
2014-08-12 7:15 ` Dexuan Cui
2014-08-12 17:54 ` Dmitry Torokhov
2014-08-12 17:54 ` Dmitry Torokhov
2014-08-12 18:01 ` KY Srinivasan
2014-08-12 18:01 ` KY Srinivasan
2014-08-13 5:27 ` Dexuan Cui
2014-08-13 5:24 ` Dexuan Cui
2014-08-13 5:24 ` Dexuan Cui
2014-08-13 15:56 ` Dmitry Torokhov
2014-08-14 6:07 ` Dexuan Cui
2016-04-18 15:23 ` [PATCH] Input: i8042 - Fix console keyboard support on Gen2 Hyper-V VMs Mark Laws
2016-04-18 15:23 ` Mark Laws
2016-04-18 16:54 ` Dan Carpenter
2016-04-18 17:24 ` Mark Laws
2016-04-18 20:36 ` Dan Carpenter
2016-04-18 22:00 ` Mark Laws
2016-04-19 8:22 ` Dan Carpenter
2016-04-19 10:46 ` Mark Laws
2016-04-22 13:00 ` Mark Laws
2016-04-22 13:01 ` Mark Laws
2016-04-22 13:17 ` Dan Carpenter
2016-04-22 17:30 ` Mark Laws
2016-04-22 17:30 ` Mark Laws
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407814240-4275-1-git-send-email-decui@microsoft.com \
--to=decui@microsoft.com \
--cc=apw@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.