From: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: [PATCH] ASoC: wm_hubs: Fix DC Servo readback
Date: Wed, 13 Aug 2014 11:47:20 +0100 [thread overview]
Message-ID: <1407926840-8576-1-git-send-email-nikesh@opensource.wolfsonmicro.com> (raw)
wm_hubs is a common driver code shared by WM8958, WM1811, WM8944
and WM8993 all these codecs have the DC Servo Values either in register
57h or 59h. Current code was reading register 58h for WM8958 and WM8994
revisions 2 and 3 but looking at the data sheet the DC Servo Values are
stored in register 57h for these codecs. This patch fixes it by reading
the correct register for DC Servo
Signed-off-by: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm_hubs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm_hubs.c b/sound/soc/codecs/wm_hubs.c
index 916817f..95c5d71 100644
--- a/sound/soc/codecs/wm_hubs.c
+++ b/sound/soc/codecs/wm_hubs.c
@@ -210,9 +210,6 @@ static int wm_hubs_read_dc_servo(struct snd_soc_codec *codec,
case 2:
dcs_reg = WM8994_DC_SERVO_4E;
break;
- case 1:
- dcs_reg = WM8994_DC_SERVO_READBACK;
- break;
default:
dcs_reg = WM8993_DC_SERVO_3;
break;
--
1.7.9.5
next reply other threads:[~2014-08-13 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 10:47 Nikesh Oswal [this message]
2014-08-13 11:08 ` [PATCH] ASoC: wm_hubs: Fix DC Servo readback Charles Keepax
2014-08-13 11:38 ` Mark Brown
2014-08-13 12:16 ` Charles Keepax
2014-08-13 12:39 ` Charles Keepax
2014-08-13 12:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407926840-8576-1-git-send-email-nikesh@opensource.wolfsonmicro.com \
--to=nikesh@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.