diff for duplicates of <1407973.m5fTNuo5v5@avalon> diff --git a/a/1.txt b/N1/1.txt index d48cd65..8cf4271 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,11 +6,11 @@ As this patch adds DT bindings, please remember to CC the devicetree mailing list (which I have CC'ed on this reply). On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: -> From: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> From: Wolfram Sang <wsa@sang-engineering.com> > > Tested with a r7s72100 genmai board acessing an eeprom. > -> Signed-off-by: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > > V2: fixed the name typo in the binding docs @@ -100,7 +100,7 @@ On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: > +/* > + * Renesas RIIC driver > + * -> + * Copyright (C) 2013 Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> + * Copyright (C) 2013 Wolfram Sang <wsa@sang-engineering.com> > + * Copyright (C) 2013 Renesas Solutions Corp. > + * > + * This program is free software; you can redistribute it and/or modify it @@ -258,7 +258,7 @@ variable can't be negative :-) > + riic->bytes_left = RIIC_INIT_MSG; > + riic->buf = msgs[i].buf; > + riic->msg = &msgs[i]; -> + riic->is_last = (i == num - 1); +> + riic->is_last = (i = num - 1); > + > + writeb(ICIER_NAKIE | ICIER_TIE, riic->base + RIIC_ICIER); > + @@ -266,7 +266,7 @@ variable can't be negative :-) > + > + ret = wait_for_completion_timeout(&riic->msg_done, > riic->adapter.timeout); -> + if (ret == 0) +> + if (ret = 0) > + riic->err = -ETIMEDOUT; > + > + if (riic->err) @@ -289,7 +289,7 @@ variable can't be negative :-) > + if (!riic->bytes_left) > + return IRQ_NONE; > + -> + if (riic->bytes_left == RIIC_INIT_MSG) { +> + if (riic->bytes_left = RIIC_INIT_MSG) { > + val = !!(riic->msg->flags & I2C_M_RD); > + if (val) > + /* On read, switch over to receive interrupt */ @@ -310,7 +310,7 @@ variable can't be negative :-) > + * after bytes_left was initialized to support SMBUS_QUICK (new msg has > + * 0 length then) > + */ -> + if (riic->bytes_left == 0) +> + if (riic->bytes_left = 0) > + riic_clear_set_bit(riic, ICIER_TIE, ICIER_TEIE, RIIC_ICIER); > + > + /* @@ -351,13 +351,13 @@ variable can't be negative :-) > + if (!riic->bytes_left) > + return IRQ_NONE; > + -> + if (riic->bytes_left == RIIC_INIT_MSG) { +> + if (riic->bytes_left = RIIC_INIT_MSG) { > + riic->bytes_left = riic->msg->len; > + readb(riic->base + RIIC_ICDRR); /* dummy read */ > + return IRQ_HANDLED; > + } > + -> + if (riic->bytes_left == 1) { +> + if (riic->bytes_left = 1) { > + /* STOP must come before we set ACKBT! */ > + if (riic->is_last) > + writeb(ICCR2_SP, riic->base + RIIC_ICCR2); @@ -563,7 +563,7 @@ optional and use a default value. What do the other I2C bus drivers usually do > +module_platform_driver(riic_i2c_driver); > + > +MODULE_DESCRIPTION("Renesas RIIC adapter"); -> +MODULE_AUTHOR("Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>"); +> +MODULE_AUTHOR("Wolfram Sang <wsa@sang-engineering.com>"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DEVICE_TABLE(of, riic_i2c_dt_ids); -- diff --git a/a/content_digest b/N1/content_digest index 2fb5bd7..2d05629 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,9 @@ "ref\01387402321-21866-1-git-send-email-wsa@the-dreams.de\0" "ref\01387402321-21866-6-git-send-email-wsa@the-dreams.de\0" - "ref\01387402321-21866-6-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org\0" - "From\0Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>\0" + "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH V2 5/5] i2c: riic: add driver\0" - "Date\0Thu, 19 Dec 2013 01:01:18 +0100\0" - "To\0Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>\0" - "Cc\0linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - " devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "Date\0Thu, 19 Dec 2013 00:01:18 +0000\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Wolfram,\n" @@ -21,11 +14,11 @@ "list (which I have CC'ed on this reply).\n" "\n" "On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote:\n" - "> From: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> From: Wolfram Sang <wsa@sang-engineering.com>\n" "> \n" "> Tested with a r7s72100 genmai board acessing an eeprom.\n" "> \n" - "> Signed-off-by: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>\n" "> ---\n" "> \n" "> V2: fixed the name typo in the binding docs\n" @@ -115,7 +108,7 @@ "> +/*\n" "> + * Renesas RIIC driver\n" "> + *\n" - "> + * Copyright (C) 2013 Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> + * Copyright (C) 2013 Wolfram Sang <wsa@sang-engineering.com>\n" "> + * Copyright (C) 2013 Renesas Solutions Corp.\n" "> + *\n" "> + * This program is free software; you can redistribute it and/or modify it\n" @@ -273,7 +266,7 @@ "> +\t\triic->bytes_left = RIIC_INIT_MSG;\n" "> +\t\triic->buf = msgs[i].buf;\n" "> +\t\triic->msg = &msgs[i];\n" - "> +\t\triic->is_last = (i == num - 1);\n" + "> +\t\triic->is_last = (i = num - 1);\n" "> +\n" "> +\t\twriteb(ICIER_NAKIE | ICIER_TIE, riic->base + RIIC_ICIER);\n" "> +\n" @@ -281,7 +274,7 @@ "> +\n" "> +\t\tret = wait_for_completion_timeout(&riic->msg_done,\n" "> riic->adapter.timeout);\n" - "> +\t\tif (ret == 0)\n" + "> +\t\tif (ret = 0)\n" "> +\t\t\triic->err = -ETIMEDOUT;\n" "> +\n" "> +\t\tif (riic->err)\n" @@ -304,7 +297,7 @@ "> +\tif (!riic->bytes_left)\n" "> +\t\treturn IRQ_NONE;\n" "> +\n" - "> +\tif (riic->bytes_left == RIIC_INIT_MSG) {\n" + "> +\tif (riic->bytes_left = RIIC_INIT_MSG) {\n" "> +\t\tval = !!(riic->msg->flags & I2C_M_RD);\n" "> +\t\tif (val)\n" "> +\t\t\t/* On read, switch over to receive interrupt */\n" @@ -325,7 +318,7 @@ "> +\t * after bytes_left was initialized to support SMBUS_QUICK (new msg has\n" "> +\t * 0 length then)\n" "> +\t */\n" - "> +\tif (riic->bytes_left == 0)\n" + "> +\tif (riic->bytes_left = 0)\n" "> +\t\triic_clear_set_bit(riic, ICIER_TIE, ICIER_TEIE, RIIC_ICIER);\n" "> +\n" "> +\t/*\n" @@ -366,13 +359,13 @@ "> +\tif (!riic->bytes_left)\n" "> +\t\treturn IRQ_NONE;\n" "> +\n" - "> +\tif (riic->bytes_left == RIIC_INIT_MSG) {\n" + "> +\tif (riic->bytes_left = RIIC_INIT_MSG) {\n" "> +\t\triic->bytes_left = riic->msg->len;\n" "> +\t\treadb(riic->base + RIIC_ICDRR);\t/* dummy read */\n" "> +\t\treturn IRQ_HANDLED;\n" "> +\t}\n" "> +\n" - "> +\tif (riic->bytes_left == 1) {\n" + "> +\tif (riic->bytes_left = 1) {\n" "> +\t\t/* STOP must come before we set ACKBT! */\n" "> +\t\tif (riic->is_last)\n" "> +\t\t\twriteb(ICCR2_SP, riic->base + RIIC_ICCR2);\n" @@ -578,7 +571,7 @@ "> +module_platform_driver(riic_i2c_driver);\n" "> +\n" "> +MODULE_DESCRIPTION(\"Renesas RIIC adapter\");\n" - "> +MODULE_AUTHOR(\"Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\");\n" + "> +MODULE_AUTHOR(\"Wolfram Sang <wsa@sang-engineering.com>\");\n" "> +MODULE_LICENSE(\"GPL v2\");\n" "> +MODULE_DEVICE_TABLE(of, riic_i2c_dt_ids);\n" "-- \n" @@ -586,4 +579,4 @@ "\n" Laurent Pinchart -d4094084abb755678bcefa36026ed10df244122cd78cf954552febad4df224c3 +1cd9f6333c1945596547d02a3970472ec3f8a0829f0b8d385d9d7adb59f8914a
diff --git a/a/1.txt b/N2/1.txt index d48cd65..2e9de81 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,11 +6,11 @@ As this patch adds DT bindings, please remember to CC the devicetree mailing list (which I have CC'ed on this reply). On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: -> From: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> From: Wolfram Sang <wsa@sang-engineering.com> > > Tested with a r7s72100 genmai board acessing an eeprom. > -> Signed-off-by: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com> > --- > > V2: fixed the name typo in the binding docs @@ -43,7 +43,7 @@ On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: > + > +Example: > + -> + i2c0: i2c@fcfee000 { +> + i2c0: i2c at fcfee000 { > + compatible = "renesas,riic-r7s72100", "renesas,riic-rz"; > + reg = <0xfcfee000 0x44>; > + interrupts = <0 157 IRQ_TYPE_LEVEL_HIGH>, @@ -100,7 +100,7 @@ On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: > +/* > + * Renesas RIIC driver > + * -> + * Copyright (C) 2013 Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org> +> + * Copyright (C) 2013 Wolfram Sang <wsa@sang-engineering.com> > + * Copyright (C) 2013 Renesas Solutions Corp. > + * > + * This program is free software; you can redistribute it and/or modify it @@ -563,7 +563,7 @@ optional and use a default value. What do the other I2C bus drivers usually do > +module_platform_driver(riic_i2c_driver); > + > +MODULE_DESCRIPTION("Renesas RIIC adapter"); -> +MODULE_AUTHOR("Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>"); +> +MODULE_AUTHOR("Wolfram Sang <wsa@sang-engineering.com>"); > +MODULE_LICENSE("GPL v2"); > +MODULE_DEVICE_TABLE(of, riic_i2c_dt_ids); -- diff --git a/a/content_digest b/N2/content_digest index 2fb5bd7..72d01f8 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,16 +1,9 @@ "ref\01387402321-21866-1-git-send-email-wsa@the-dreams.de\0" "ref\01387402321-21866-6-git-send-email-wsa@the-dreams.de\0" - "ref\01387402321-21866-6-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org\0" - "From\0Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>\0" - "Subject\0Re: [PATCH V2 5/5] i2c: riic: add driver\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH V2 5/5] i2c: riic: add driver\0" "Date\0Thu, 19 Dec 2013 01:01:18 +0100\0" - "To\0Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>\0" - "Cc\0linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" - linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> - linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org - " devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Wolfram,\n" @@ -21,11 +14,11 @@ "list (which I have CC'ed on this reply).\n" "\n" "On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote:\n" - "> From: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> From: Wolfram Sang <wsa@sang-engineering.com>\n" "> \n" "> Tested with a r7s72100 genmai board acessing an eeprom.\n" "> \n" - "> Signed-off-by: Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>\n" "> ---\n" "> \n" "> V2: fixed the name typo in the binding docs\n" @@ -58,7 +51,7 @@ "> +\n" "> +Example:\n" "> +\n" - "> +\ti2c0: i2c@fcfee000 {\n" + "> +\ti2c0: i2c at fcfee000 {\n" "> +\t\tcompatible = \"renesas,riic-r7s72100\", \"renesas,riic-rz\";\n" "> +\t\treg = <0xfcfee000 0x44>;\n" "> +\t\tinterrupts = <0 157 IRQ_TYPE_LEVEL_HIGH>,\n" @@ -115,7 +108,7 @@ "> +/*\n" "> + * Renesas RIIC driver\n" "> + *\n" - "> + * Copyright (C) 2013 Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\n" + "> + * Copyright (C) 2013 Wolfram Sang <wsa@sang-engineering.com>\n" "> + * Copyright (C) 2013 Renesas Solutions Corp.\n" "> + *\n" "> + * This program is free software; you can redistribute it and/or modify it\n" @@ -578,7 +571,7 @@ "> +module_platform_driver(riic_i2c_driver);\n" "> +\n" "> +MODULE_DESCRIPTION(\"Renesas RIIC adapter\");\n" - "> +MODULE_AUTHOR(\"Wolfram Sang <wsa-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>\");\n" + "> +MODULE_AUTHOR(\"Wolfram Sang <wsa@sang-engineering.com>\");\n" "> +MODULE_LICENSE(\"GPL v2\");\n" "> +MODULE_DEVICE_TABLE(of, riic_i2c_dt_ids);\n" "-- \n" @@ -586,4 +579,4 @@ "\n" Laurent Pinchart -d4094084abb755678bcefa36026ed10df244122cd78cf954552febad4df224c3 +ae0af6272bfc10be0dcdb72db8e8d2c29a31a025ff80a858a0f3a5aa2db2b80a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.