From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssl: Repace if-else with case and add musl triplet
Date: Fri, 15 Aug 2014 18:17:45 +0100 [thread overview]
Message-ID: <1408123065.21596.32.camel@ted> (raw)
In-Reply-To: <1408009882-28210-1-git-send-email-raj.khem@gmail.com>
On Thu, 2014-08-14 at 02:51 -0700, Khem Raj wrote:
> Simplifies the code and adds knowlwdge about musl targets
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-connectivity/openssl/openssl.inc | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
This breaks x32 builds:
https://autobuilder.yoctoproject.org/main/builders/nightly-x32/builds/204/steps/BuildImages/logs/stdio
(target doesn't end up set to linux-x32 which it needs to be)
Cheers,
Richard
> diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
> index b839c00..e585dbb 100644
> --- a/meta/recipes-connectivity/openssl/openssl.inc
> +++ b/meta/recipes-connectivity/openssl/openssl.inc
> @@ -60,17 +60,15 @@ do_configure () {
> ln -sf apps/openssl.pod crypto/crypto.pod ssl/ssl.pod doc/
>
> os=${HOST_OS}
> - if [ "x$os" = "xlinux-uclibc" ]; then
> + case $os in
> + linux-uclibc* |\
> + linux-musl* |\
> + linux-gnu*)
> os=linux
> - elif [ "x$os" = "xlinux-uclibceabi" ]; then
> - os=linux
> - elif [ "x$os" = "xlinux-uclibcspe" ]; then
> - os=linux
> - elif [ "x$os" = "xlinux-gnuspe" ]; then
> - os=linux
> - elif [ "x$os" = "xlinux-gnueabi" ]; then
> - os=linux
> - fi
> + ;;
> + *)
> + ;;
> + esac
> target="$os-${HOST_ARCH}"
> case $target in
> linux-arm)
> --
> 1.7.10.4
>
next prev parent reply other threads:[~2014-08-15 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 9:51 [PATCH] openssl: Repace if-else with case and add musl triplet Khem Raj
2014-08-15 17:17 ` Richard Purdie [this message]
2014-08-16 1:34 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408123065.21596.32.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.