* [PATCH] cpufreq: exynos: free memory immediately on unknown SoC
@ 2014-08-17 4:06 ` Arjun Sreedharan
0 siblings, 0 replies; 4+ messages in thread
From: Arjun Sreedharan @ 2014-08-17 4:06 UTC (permalink / raw)
To: viresh.kumar
Cc: rjw, kgene.kim, linux-pm, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
---
drivers/cpufreq/exynos-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 1e0ec57..e47d165 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
ret = exynos5250_cpufreq_init(exynos_info);
} else {
pr_err("%s: Unknown SoC type\n", __func__);
+ kfree(exynos_info);
return -ENODEV;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cpufreq: exynos: free memory immediately on unknown SoC
@ 2014-08-17 4:06 ` Arjun Sreedharan
0 siblings, 0 replies; 4+ messages in thread
From: Arjun Sreedharan @ 2014-08-17 4:06 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
---
drivers/cpufreq/exynos-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 1e0ec57..e47d165 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
ret = exynos5250_cpufreq_init(exynos_info);
} else {
pr_err("%s: Unknown SoC type\n", __func__);
+ kfree(exynos_info);
return -ENODEV;
}
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: exynos: free memory immediately on unknown SoC
2014-08-17 4:06 ` Arjun Sreedharan
@ 2014-08-18 7:59 ` Viresh Kumar
-1 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2014-08-18 7:59 UTC (permalink / raw)
To: Arjun Sreedharan
Cc: Rafael J. Wysocki, Kukjin Kim, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-samsung-soc,
Linux Kernel Mailing List
On 17 August 2014 09:36, Arjun Sreedharan <arjun024@gmail.com> wrote:
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 1e0ec57..e47d165 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
> ret = exynos5250_cpufreq_init(exynos_info);
> } else {
> pr_err("%s: Unknown SoC type\n", __func__);
> + kfree(exynos_info);
> return -ENODEV;
> }
Apart from the fact that we could have added some logs and improved
$subject a bit,
it looks fine.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cpufreq: exynos: free memory immediately on unknown SoC
@ 2014-08-18 7:59 ` Viresh Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2014-08-18 7:59 UTC (permalink / raw)
To: linux-arm-kernel
On 17 August 2014 09:36, Arjun Sreedharan <arjun024@gmail.com> wrote:
> Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
> ---
> drivers/cpufreq/exynos-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 1e0ec57..e47d165 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -178,6 +178,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev)
> ret = exynos5250_cpufreq_init(exynos_info);
> } else {
> pr_err("%s: Unknown SoC type\n", __func__);
> + kfree(exynos_info);
> return -ENODEV;
> }
Apart from the fact that we could have added some logs and improved
$subject a bit,
it looks fine.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-18 7:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-17 4:06 [PATCH] cpufreq: exynos: free memory immediately on unknown SoC Arjun Sreedharan
2014-08-17 4:06 ` Arjun Sreedharan
2014-08-18 7:59 ` Viresh Kumar
2014-08-18 7:59 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.