From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: edward.shishkin@gmail.com, Ivan Shapovalov <intelfx100@gmail.com>
Subject: [RFC] [PATCHv3 5/9] reiser4: txnmgr: call reiser4_post_write_back_hook() also for empty atoms.
Date: Mon, 18 Aug 2014 01:52:55 +0400 [thread overview]
Message-ID: <1408312379-1990-6-git-send-email-intelfx100@gmail.com> (raw)
In-Reply-To: <1408312379-1990-1-git-send-email-intelfx100@gmail.com>
The atoms generated by reiser4_trim_fs(), despite being empty (zero
capture_count), still have non-empty delete sets which have to be
processed.
Also the empty atom check has been moved after changing atom stage
to ASTAGE_PRE_COMMIT, because reiser4_post_write_back_hook() requires
atom to be unlocked.
Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
---
fs/reiser4/txnmgr.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/fs/reiser4/txnmgr.c b/fs/reiser4/txnmgr.c
index 2862940..2efdf85 100644
--- a/fs/reiser4/txnmgr.c
+++ b/fs/reiser4/txnmgr.c
@@ -1064,9 +1064,6 @@ static int commit_current_atom(long *nr_submitted, txn_atom ** atom)
return RETERR(-E_REPEAT);
}
- if ((*atom)->capture_count == 0)
- goto done;
-
/* Up to this point we have been flushing and after flush is called we
return -E_REPEAT. Now we can commit. We cannot return -E_REPEAT
at this point, commit should be successful. */
@@ -1074,6 +1071,14 @@ static int commit_current_atom(long *nr_submitted, txn_atom ** atom)
ON_DEBUG(((*atom)->committer = current));
spin_unlock_atom(*atom);
+ if ((*atom)->capture_count == 0) {
+ /* Process the atom's delete set.
+ * Even if the atom has no captured nodes, the delete set may
+ * still be non-empty (see e. g. reiser4_trim_fs()). */
+ reiser4_post_write_back_hook();
+ goto done;
+ }
+
ret = current_atom_complete_writes();
if (ret)
return ret;
@@ -1100,8 +1105,8 @@ static int commit_current_atom(long *nr_submitted, txn_atom ** atom)
reiser4_invalidate_list(ATOM_WB_LIST(*atom));
assert("zam-927", list_empty(&(*atom)->inodes));
+done:
spin_lock_atom(*atom);
- done:
reiser4_atom_set_stage(*atom, ASTAGE_DONE);
ON_DEBUG((*atom)->committer = NULL);
--
2.0.4
next prev parent reply other threads:[~2014-08-17 21:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 21:52 [RFC] [PATCHv3 0/9] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 1/9] reiser4: block_alloc: add BA_SOME_SPACE flag for grabbing a fixed amount of space Ivan Shapovalov
2014-10-19 22:04 ` Edward Shishkin
2014-10-20 10:36 ` Ivan Shapovalov
2014-10-21 10:32 ` Edward Shishkin
2014-10-21 16:17 ` Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 2/9] reiser4: block_alloc: add a "forward" parameter to reiser4_blocknr_hint to allocate blocks only in forward direction Ivan Shapovalov
2014-10-21 15:50 ` Edward Shishkin
2014-10-23 7:24 ` Ivan Shapovalov
2014-10-23 14:37 ` Edward Shishkin
2014-10-23 20:58 ` Ivan Shapovalov
2014-10-26 16:45 ` Edward Shishkin
2014-10-26 23:21 ` Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 3/9] reiser4: txnmgr: free allocated but unneeded atom in atom_begin_and_assign_to_txnh() Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 4/9] reiser4: txnmgr: add reiser4_create_atom() which creates an empty atom without capturing any nodes Ivan Shapovalov
2014-08-17 21:52 ` Ivan Shapovalov [this message]
2014-08-17 21:52 ` [RFC] [PATCHv3 6/9] reiser4: batch discard support: add a dummy FITRIM ioctl handler for directories Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 7/9] reiser4: batch discard support: actually implement the FITRIM ioctl handler Ivan Shapovalov
2014-10-20 10:54 ` Edward Shishkin
2014-10-20 22:39 ` Ivan Shapovalov
2014-10-21 10:14 ` Edward Shishkin
2014-10-21 16:18 ` Ivan Shapovalov
2014-10-21 16:21 ` Edward Shishkin
2014-10-21 16:23 ` Ivan Shapovalov
2014-10-21 16:33 ` Edward Shishkin
2014-10-21 16:42 ` Ivan Shapovalov
2014-10-21 18:01 ` Edward Shishkin
2014-10-21 18:11 ` Ivan Shapovalov
2014-10-21 18:48 ` Edward Shishkin
2014-10-21 19:00 ` Ivan Shapovalov
2014-10-21 19:13 ` Edward Shishkin
2014-08-17 21:52 ` [RFC] [PATCHv3 8/9] reiser4: block_alloc: add a "min_len" parameter to reiser4_blocknr_hint to limit allocated extent length from below Ivan Shapovalov
2014-08-17 21:52 ` [RFC] [PATCHv3 9/9] reiser4: batch discard support: honor minimal extent length passed from the userspace Ivan Shapovalov
2014-08-17 21:56 ` [RFC] [PATCHv3 0/9] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408312379-1990-6-git-send-email-intelfx100@gmail.com \
--to=intelfx100@gmail.com \
--cc=edward.shishkin@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.