From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen/tools: Introduce QNX IFS loader Date: Wed, 20 Aug 2014 12:11:06 +0200 Message-ID: <1408529466.3725.84.camel@Solace.lan> References: <1408463462-19568-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <53F3778E.4020109@citrix.com> <1408465606.3725.53.camel@Solace.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7511296147461125338==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Artem Mygaiev Cc: Lars Kurth , Ian Campbell , Andrew Cooper , Brian Warner , "julien.grall@linaro.org" , "Tim (Xen.org)" , "xen-devel@lists.xen.org" , Oleksandr Tyshchenko , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============7511296147461125338== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-8e17JZvQK3OI6CYV3gXR" --=-8e17JZvQK3OI6CYV3gXR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2014-08-20 at 13:07 +0300, Artem Mygaiev wrote: > Lars, let me comment here. Apache 2 license is used on reference > loader supplied by QNX to allow re-use code of the reference > implementation, so it is OK to stick to it here. >=20 Yeah but, AFAIUI, the problem here is that it is *not* ok to have Apache2 licensed code in libxc... :-( Regards, Dario > >>On mar, 2014-08-19 at 17:13 +0100, Andrew Cooper wrote: > >>> On 19/08/14 16:51, Oleksandr Tyshchenko wrote: > >>> > Add ability to load QNX IFS image. Based on IPL code (U-Boot for QN= X). > >>> > > >>> > Signed-off-by: Oleksandr Tyshchenko > >>> > >>> > --- > >>> > tools/libxc/Makefile | 1 + > >>> > tools/libxc/xc_dom_qnxifsloader.c | 189 > >>>++++++++++++++++++++++++++++++++++++++ > >>> > 2 files changed, 190 insertions(+) > >>> > create mode 100644 tools/libxc/xc_dom_qnxifsloader.c > >>> > > >>> > diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile > >>> > index 22eef8e..812cc7e 100644 > >>> > --- a/tools/libxc/Makefile > >>> > +++ b/tools/libxc/Makefile > >>> > @@ -67,6 +67,7 @@ GUEST_SRCS-y +=3D xc_dom_elfloade= r.c > >>> > GUEST_SRCS-$(CONFIG_X86) +=3D xc_dom_bzimageloader.c > >>> > GUEST_SRCS-$(CONFIG_X86) +=3D xc_dom_decompress_lz4.c > >>> > GUEST_SRCS-$(CONFIG_ARM) +=3D xc_dom_armzimageloader.c > >>> > +GUEST_SRCS-$(CONFIG_ARM) +=3D xc_dom_qnxifsloader.c > >>> > GUEST_SRCS-y +=3D xc_dom_binloader.c > >>> > GUEST_SRCS-y +=3D xc_dom_compat_linux.c > >>> > > >>> > diff --git a/tools/libxc/xc_dom_qnxifsloader.c > >>>b/tools/libxc/xc_dom_qnxifsloader.c > >>> > new file mode 100644 > >>> > index 0000000..45d007d > >>> > --- /dev/null > >>> > +++ b/tools/libxc/xc_dom_qnxifsloader.c > >>> > @@ -0,0 +1,189 @@ > >>> > +/* > >>> > + * Xen domain builder -- QNX IFS bits > >>> > + * > >>> > + * Parse and load QNX IFS image. > >>> > + * > >>> > + * Copyright (C) 2014, Globallogic. > >>> > + * > >>> > + * Licensed under the Apache License, Version 2.0 (the "License"). > >>>You > >>> > + * may not reproduce, modify or distribute this software except in > >>> > + * compliance with the License. You may obtain a copy of the Licen= se > >>> > + * at: http://www.apache.org/licenses/LICENSE-2.0 > >>> > + * > >>> > + * Unless required by applicable law or agreed to in writing, > >>>software > >>> > + * distributed under the License is distributed on an "AS IS" basi= s, > >>> > + * WITHOUT WARRANTIES OF ANY KIND, either express or implied. > >>> > + * > >>> > + * This file may contain contributions from others, either as > >>> > + * contributors under the License or as licensors under other term= s. > >>> > + * Please review this entire file for other proprietary rights or > >>>license > >>> > + * notices, as well as the QNX Development Suite License Guide at > >>> > + * http://licensing.qnx.com/license-guide/ for other information. > >>> > + */ > >>> > >>> The rest of libxc is licensed under GPLv2.1, which is incompatible wi= th > >>> Apache 2.0 > > > > That is correct. > > > > The question is whether this code needs to be Apache 2.0. My understand= ing > > was that the QNX recommendation is that a base port of QNX (aka the > > drivers) are recommended to be Apache 2. But it is not clear to me whet= her > > the boot loader needs to be. I don=C2=B9t have enough context and can= =C2=B9t find > > any reference to the file system itself in the license guide. > > > > I do not know enough about the subtleties of licenses here and am addin= g > > Brian, in case we need to get some more advice on how to mitigate this > > issue. > > > > @Oleksandr, can you also check with your legal guys? > > > > Regards > > Lars > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-8e17JZvQK3OI6CYV3gXR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlP0dDoACgkQk4XaBE3IOsRr3gCgnaKPk+yi41FgTwy/66gRvZ7B FPoAoIzNQq1YuQSoPf+t49IxF2k0BpIw =/vyf -----END PGP SIGNATURE----- --=-8e17JZvQK3OI6CYV3gXR-- --===============7511296147461125338== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7511296147461125338==--