From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 86D9E1A01DD for ; Thu, 21 Aug 2014 14:41:30 +1000 (EST) Message-ID: <1408596086.9307.3.camel@concordia> Subject: Re: [PATCH] powerpc/pseries: Drop unnecessary continue From: Michael Ellerman To: Himangi Saraogi Date: Thu, 21 Aug 2014 14:41:26 +1000 In-Reply-To: <20140813091847.GA3078@himangi-Dell> References: <20140813091847.GA3078@himangi-Dell> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linux-kernel@vger.kernel.org, Julia Lawall , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, rcj4747@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: > Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer loop? I stared at it for a minute but it wasn't obvious. I wonder if Robert still remembers? cheers > diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c > index 2d8bf15..fc44ad0 100644 > --- a/arch/powerpc/platforms/pseries/cmm.c > +++ b/arch/powerpc/platforms/pseries/cmm.c > @@ -555,7 +555,6 @@ static int cmm_mem_going_offline(void *arg) > pa_last = pa_last->next; > free_page((unsigned long)cmm_page_list); > cmm_page_list = pa_last; > - continue; > } > } > pa_curr = pa_curr->next; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753116AbaHUElc (ORCPT ); Thu, 21 Aug 2014 00:41:32 -0400 Received: from ozlabs.org ([103.22.144.67]:59668 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbaHUElb (ORCPT ); Thu, 21 Aug 2014 00:41:31 -0400 Message-ID: <1408596086.9307.3.camel@concordia> Subject: Re: [PATCH] powerpc/pseries: Drop unnecessary continue From: Michael Ellerman To: Himangi Saraogi Cc: benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Julia Lawall , rcj4747@gmail.com Date: Thu, 21 Aug 2014 14:41:26 +1000 In-Reply-To: <20140813091847.GA3078@himangi-Dell> References: <20140813091847.GA3078@himangi-Dell> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: > Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer loop? I stared at it for a minute but it wasn't obvious. I wonder if Robert still remembers? cheers > diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c > index 2d8bf15..fc44ad0 100644 > --- a/arch/powerpc/platforms/pseries/cmm.c > +++ b/arch/powerpc/platforms/pseries/cmm.c > @@ -555,7 +555,6 @@ static int cmm_mem_going_offline(void *arg) > pa_last = pa_last->next; > free_page((unsigned long)cmm_page_list); > cmm_page_list = pa_last; > - continue; > } > } > pa_curr = pa_curr->next;