From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 677BD3DCD94 for ; Wed, 5 Aug 2026 09:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923339; cv=none; b=CJK99adh7dM6fYK54SPfvyW9kPeNuko6gKb/a88LJlTM2gwf0EfTrWEzdXwTjG40JjhanA4ipFD/SP1PWRSMJXzHjbRrpElRitiAvrv/13wIDOSjgXGvi/ka45M0NSTMwlQO6dSPtVucXzzf+pOayD7RtvuEpfh1vOt0vLjKfm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785923339; c=relaxed/simple; bh=c8gIqr5gEyy/IjtvuALFCWVffOz/nDlF66n+wckL2Y8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ihcw0LJjvG95xEmJvoiPi5JIL9a8Kqz68smvuUmu01HFone4bCNlb4zr5bN7fiAGAw+KoCSZURc0Z6oBkFXiCSacE3dCJmVuaahU2y5l8AyLiKL4R9zllmmGuq6/4D32xGAtPRblCc90l5kqyFXQoh3ALoxCRy3ZWi7xgv9lU1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wmo2/7Oq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wmo2/7Oq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785923336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hYkdfyYK4QIDZSwd+PfhkieuFeQWFAYiWHPRlo9WZAI=; b=Wmo2/7OqL9Un1/AcQ0IIiaL7r7iXplAASz/DXXnpRduGuFTpFPEVd5NFBHxOd6oE7K5QiG LVO7zymeb4SzPl3MALhnsz1QWw6XTVo0XkOSpgcgT0FucYYa4XknTR5Jfzxr8a4d3GeCxy k044aqP0kI/VkDKvJw72tKRX9aubYUE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-DjlDp5tKOSGAEchIFUFENA-1; Wed, 05 Aug 2026 05:48:52 -0400 X-MC-Unique: DjlDp5tKOSGAEchIFUFENA-1 X-Mimecast-MFC-AGG-ID: DjlDp5tKOSGAEchIFUFENA_1785923331 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C9FE1955F15; Wed, 5 Aug 2026 09:48:50 +0000 (UTC) Received: from [10.44.32.154] (unknown [10.44.32.154]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12362195DF91; Wed, 5 Aug 2026 09:48:46 +0000 (UTC) Message-ID: <14086fc7-b8f3-47a4-87a4-5e02882b6bf1@redhat.com> Date: Wed, 5 Aug 2026 11:48:45 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 1/2] dpll: zl3073x: add channel ToD, phase step and TIE operations To: Vadim Fedorenko , netdev@vger.kernel.org Cc: Petr Oros , Chris du Quesnay , Arkadiusz Kubalewski , Jakub Kicinski , Jiri Pirko , Paolo Abeni , Prathosh Satish , Richard Cochran , linux-kernel@vger.kernel.org References: <20260803140637.102339-1-ivecera@redhat.com> <20260803140637.102339-2-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 8/5/26 1:07 AM, Vadim Fedorenko wrote: > On 03/08/2026 15:06, Ivan Vecera wrote: >> Add low-level DPLL channel operations for ToD read/write/adjust, >> output phase step, delta frequency offset write and TIE (Time >> Interval Error) write. These serve as building blocks for the PTP >> clock callbacks added in the next patch. >> >> ToD operations use a wait-before-write pattern to avoid blocking >> after each operation. >> >> The tod_ready_wait helper selects the poll timeout based on the >> current ToD command - write operations use a longer timeout (1000 ms) >> than reads (30 ms). >> >> The ToD read captures system timestamps (ptp_system_timestamp) around >> the HW command and completion poll to support cross-timestamping. >> >> The TIE write operation provides sub-picosecond resolution phase >> adjustment for modes where the DPLL is tracking a reference >> (AUTO and REFLOCK). >> >> Add output step-time mask to struct zl3073x_dev and >> zl3073x_dev_out_is_stepped() helper to check if an output >> participates in step-time operations. >> >> Reviewed-by: Petr Oros >> Tested-by: Chris du Quesnay >> Signed-off-by: Ivan Vecera >> --- >>   drivers/dpll/zl3073x/chan.c | 310 +++++++++++++++++++++++++++++++++++- >>   drivers/dpll/zl3073x/chan.h |  32 ++++ >>   drivers/dpll/zl3073x/core.c |  13 ++ >>   drivers/dpll/zl3073x/core.h |  23 +++ >>   drivers/dpll/zl3073x/regs.h |  52 ++++++ >>   5 files changed, 428 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/dpll/zl3073x/chan.c b/drivers/dpll/zl3073x/chan.c >> index 4ec2cf53dad468..79874a9fdb4962 100644 >> --- a/drivers/dpll/zl3073x/chan.c >> +++ b/drivers/dpll/zl3073x/chan.c >> @@ -3,6 +3,7 @@ >>   #include >>   #include >>   #include >> +#include >>   #include >>   #include >> @@ -162,8 +163,8 @@ int zl3073x_chan_nco_mode_set(struct zl3073x_dev >> *zldev, u8 index) >>    * @zldev: pointer to zl3073x_dev structure >>    * @index: DPLL channel index to fetch state for >>    * >> - * Reads the mode_refsel register and reference priority registers for >> - * the given DPLL channel and stores the raw values for later use. >> + * Reads the mode_refsel, status and reference priority registers for >> + * the given DPLL channel and stores the values for later use. >>    * >>    * Return: 0 on success, <0 on error >>    */ >> @@ -234,6 +235,311 @@ const struct zl3073x_chan >> *zl3073x_chan_state_get(struct zl3073x_dev *zldev, >>       return &zldev->chan[index]; >>   } >> +/** >> + * zl3073x_chan_tod_ready_wait - wait for ToD semaphore to clear >> + * @zldev: pointer to zl3073x device >> + * @ch: DPLL channel index >> + * >> + * Polls the ToD control register until the semaphore bit is cleared, >> + * indicating the device has completed the previous ToD operation. >> + * >> + * Return: 0 on success, -EBUSY if semaphore not cleared, <0 on error >> + */ >> +int zl3073x_chan_tod_ready_wait(struct zl3073x_dev *zldev, u8 ch) >> +{ >> +    unsigned int timeout; >> +    u8 tod_ctrl; >> +    int rc; >> + >> +    rc = zl3073x_read_u8(zldev, ZL_REG_DPLL_TOD_CTRL(ch), &tod_ctrl); >> +    if (rc) >> +        return rc; >> + >> +    switch (FIELD_GET(ZL_DPLL_TOD_CTRL_CMD, tod_ctrl)) { >> +    case ZL_DPLL_TOD_CTRL_CMD_WR_NEXT_1HZ: >> +        timeout = ZL_POLL_TOD_WR_TIMEOUT_US; >> +        break; >> +    default: >> +        timeout = ZL_POLL_TOD_RD_TIMEOUT_US; >> +        break; >> +    } > > there are 3 cmds defined, but FIELD_GET(ZL_DPLL_TOD_CTRL_CMD) can return > up to 16 possible values. I would explicitly put defined commands in > cases and make default to ENOTSUPP.. Hi Vadim, the ZL_DPLL_TOD_CTRL_CMD bits are never filled by firmware (only the semaphore bit) so the driver knows what it writes. So such check is not necessary but if you want it I can add something like: ... case ZL_DPLL_TOD_CTRL_CMD_RD_CURRENT: case ZL_DPLL_TOD_CTRL_CMD_RD_NEXT_1HZ: timeout = ZL_POLL_TOD_RD_TIMEOUT_US; break; default: WARN_ON(1); /* this is really unexpected */ return -ENOTSUPP; ... Let me know. Thanks, Ivan