All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Keir Fraser <keir@xen.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH 07/13] tools/pygrub: store kernels in /var/run/xen/pygrub
Date: Tue, 26 Aug 2014 21:04:14 +0100	[thread overview]
Message-ID: <1409083454.28009.23.camel@citrix.com> (raw)
In-Reply-To: <1406538316-29087-8-git-send-email-olaf@aepfle.de>

On Mon, 2014-07-28 at 11:05 +0200, Olaf Hering wrote:
> Move location of temporary bootfiles from /var/run/xend/boot to
> /var/run/xen/pygrub. Create the subdirectory if does not exist.
> The <dir> argument --output-directory must be an existing directory.
> 
> The reason for this change is that all entrys below /var/run have to be
> created at runtime in case /var/run is cleared on every boot.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  tools/pygrub/src/pygrub | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/pygrub/src/pygrub b/tools/pygrub/src/pygrub
> index 2618e11..9d8c5a1 100644
> --- a/tools/pygrub/src/pygrub
> +++ b/tools/pygrub/src/pygrub
> @@ -14,6 +14,7 @@
>  #
>  
>  import os, sys, string, struct, tempfile, re, traceback
> +import errno

Isn't this unused? If so then with it removed:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

If it is used then the ack applies to the patch unchanged ;-)

  reply	other threads:[~2014-08-26 20:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28  9:05 [PATCH 00/13 v2] tools changes to honor --prefix= Olaf Hering
2014-07-28  9:05 ` [PATCH 01/13] Config.mk: move directory list into BUILD_MAKE_VARS Olaf Hering
2014-07-28  9:05 ` [PATCH 02/13] Config.mk: replace dependency to genpath with actual target Olaf Hering
2014-08-26 20:00   ` Ian Campbell
2014-08-27  8:36     ` Olaf Hering
2014-08-28 17:34       ` Ian Campbell
2014-08-29  6:33         ` Olaf Hering
2014-09-03 10:28           ` Ian Campbell
2014-09-03 10:43             ` Olaf Hering
2014-09-17 10:02   ` Olaf Hering
2014-09-17 16:53     ` Ian Campbell
2014-09-18  8:09       ` Olaf Hering
2014-09-18 17:44         ` Ian Campbell
2014-09-19  6:55           ` Olaf Hering
2014-07-28  9:05 ` [PATCH 03/13] Config.mk: add new macro buildmakevars2header Olaf Hering
2014-08-26 20:02   ` Ian Campbell
2014-07-28  9:05 ` [PATCH 04/13] tools/libxl: use buildmakevars2header to create _paths.h Olaf Hering
2014-07-28  9:05 ` [PATCH 05/13] tools/libxc: provide variable paths to libxc Olaf Hering
2014-07-28  9:05 ` [PATCH 06/13] tools/libxc: use XEN_RUN_DIR for SUSPEND_LOCK_FILE Olaf Hering
2014-07-28  9:05 ` [PATCH 07/13] tools/pygrub: store kernels in /var/run/xen/pygrub Olaf Hering
2014-08-26 20:04   ` Ian Campbell [this message]
2014-07-28  9:05 ` [PATCH 08/13] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path Olaf Hering
2014-08-26 20:07   ` Ian Campbell
2014-08-27  8:42     ` Olaf Hering
2014-07-28  9:05 ` [PATCH 09/13] tools/hotplug: create XEN_RUN_DIR at runtime Olaf Hering
2014-07-28  9:05 ` [PATCH 10/13] tools/hotplug: create XEN_LOCK_DIR " Olaf Hering
2014-07-28  9:05 ` [PATCH 11/13] tools/hotplug: use XEN_LOCK_DIR instead of hardcoded path Olaf Hering
2014-08-26 20:08   ` Ian Campbell
2014-07-28  9:05 ` [PATCH 12/13] tools/examples: remove obsolete install targets Olaf Hering
2014-07-28  9:05 ` [PATCH 13/13] remove obsolete SUBSYS_DIR variable Olaf Hering
2014-08-26 20:08   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409083454.28009.23.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=olaf@aepfle.de \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.