From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/libxc: Set max_elem to zero in xc_lockprof_query_number() Date: Tue, 26 Aug 2014 22:13:13 +0100 Message-ID: <1409087593.28009.49.camel@citrix.com> References: <1407948038-13998-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XMO3Z-0001i3-SM for xen-devel@lists.xenproject.org; Tue, 26 Aug 2014 21:13:33 +0000 In-Reply-To: <1407948038-13998-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-08-13 at 12:40 -0400, Boris Ostrovsky wrote: > If max_elem is not zero then hypervisor's spinlock_profile_ucopy_elem() > will attempt to copy profile data into user's data buffer. Since this > buffer is explicitly set to (the equivalent of) NULL the copy will fail, > causing xenlockprof to fail as well. > > Signed-off-by: Boris Ostrovsky I would have expected DECLARE_SYSCTL to zero the struct, but anyway: Acked + applied, thanks (and sorry for the delay).