From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] systemtap: Fixed probe syscall.sendfile failure
Date: Thu, 28 Aug 2014 11:33:29 +0100 [thread overview]
Message-ID: <1409222009.29296.137.camel@ted> (raw)
In-Reply-To: <1409221034-24748-1-git-send-email-muzaffar_mahmood@mentor.com>
On Thu, 2014-08-28 at 15:17 +0500, Muzaffar Mahmood wrote:
> From: Mikhail Durnev <mikhail_durnev@mentor.com>
>
> Marked __syscall.compat_sendfile as optional
>
> Signed-off-by: Mikhail Durnev <mikhail_durnev@mentor.com>
> Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
> ---
This says what you did but not why. There is nothing at all in the patch
header, no Upstream-Status, no description, no author.
Cheers,
Richard
> .../systemtap/tapset-linux-sendfile-syscall.patch | 12 ++++++++++++
> meta/recipes-kernel/systemtap/systemtap_git.inc | 1 +
> 2 files changed, 13 insertions(+)
> create mode 100644 meta/recipes-kernel/systemtap/systemtap/tapset-linux-sendfile-syscall.patch
>
> diff --git a/meta/recipes-kernel/systemtap/systemtap/tapset-linux-sendfile-syscall.patch b/meta/recipes-kernel/systemtap/systemtap/tapset-linux-sendfile-syscall.patch
> new file mode 100644
> index 0000000..b42ab3c
> --- /dev/null
> +++ b/meta/recipes-kernel/systemtap/systemtap/tapset-linux-sendfile-syscall.patch
> @@ -0,0 +1,12 @@
> +diff -Naur old/tapset/linux/syscalls2.stp new/tapset/linux/syscalls2.stp
> +--- old/tapset/linux/syscalls2.stp 2014-04-21 01:28:41.000000000 -0500
> ++++ new/tapset/linux/syscalls2.stp 2014-04-21 01:38:14.961233914 -0500
> +@@ -1953,7 +1953,7 @@
> + # COMPAT_SYSCALL_DEFINE4(sendfile64, int, out_fd, int, in_fd,
> + # compat_loff_t __user *, offset, compat_size_t, count)
> + #
> +-probe syscall.sendfile = __syscall.sendfile, __syscall.compat_sendfile
> ++probe syscall.sendfile = __syscall.sendfile, __syscall.compat_sendfile ?
> + {
> + name = "sendfile"
> + out_fd = __int32($out_fd)
> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
> index 717d66f..3e1e80a 100644
> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> @@ -6,6 +6,7 @@ PV = "2.5+git${SRCPV}"
> SRC_URI = "git://sourceware.org/git/systemtap.git \
> file://docproc-build-fix.patch \
> file://obsolete_automake_macros.patch \
> + file://tapset-linux-sendfile-syscall.patch \
> "
>
> # systemtap doesn't support mips
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-08-28 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 10:17 [PATCH] systemtap: Fixed probe syscall.sendfile failure Muzaffar Mahmood
2014-08-28 10:33 ` Richard Purdie [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-03 8:14 Muzaffar Mahmood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409222009.29296.137.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=muzaffar_mahmood@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.