From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Feng Tang <feng.tang@intel.com>,
linux-spi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] spi: dw-mid: don't leak memory on exit
Date: Fri, 29 Aug 2014 10:35:15 +0300 [thread overview]
Message-ID: <1409297715.30155.27.camel@linux.intel.com> (raw)
In-Reply-To: <20140828181922.GJ29327@sirena.org.uk>
On Thu, 2014-08-28 at 19:19 +0100, Mark Brown wrote:
> On Thu, Aug 28, 2014 at 11:53:17AM +0300, Andy Shevchenko wrote:
> > When built with DMA support the memory for an internal structure is allocated
> > but not freed. Converting to devm_kzalloc solves the issue.
> >
> > Fixes: 7063c0d942a1 (spi/dw_spi: add DMA support)
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: <stable@vger.kernel.org> # v2.6.38+
>
> You've sent two versions of this with different changelogs and diffs -
> what's the story there?
Sorry for confusion.
There are two different fixes against MID support.
One of them to protect against crash on removal, another is this one.
> This doesn't seem like an obvious stable candidate - it's a leak fix on
> probe.
Yes, I may agree with you. Then, please, do not consider this one. It
would be a part of a patches against spi-dw-mid.c
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
prev parent reply other threads:[~2014-08-29 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:53 [PATCH] spi: dw-mid: don't leak memory on exit Andy Shevchenko
2014-08-28 18:19 ` Mark Brown
2014-08-29 7:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409297715.30155.27.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=feng.tang@intel.com \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.