All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Cc: vladimir.murzin-5wv7dgnIgG8@public.gmane.org,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org,
	jroedel-l3A5Bk7waGM@public.gmane.org
Subject: [PATCH 4/7] iommu/arm-smmu: fix programming of SMMU_CBn_TCR for stage 1
Date: Fri, 29 Aug 2014 15:47:42 +0100	[thread overview]
Message-ID: <1409323665-9605-5-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1409323665-9605-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>

From: Olav Haugan <ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>

Stage-1 context banks do not have the SMMU_CBn_TCR[SL0] field since it
is only applicable to stage-2 context banks.

This patch ensures that we don't set the reserved TCR bits for stage-1
translations.

Signed-off-by: Olav Haugan <ohaugan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Signed-off-by: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
---
 drivers/iommu/arm-smmu.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 34dc7b1cec3c..b03959ddb32c 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -854,8 +854,11 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain)
 	reg |= TTBCR_EAE |
 	      (TTBCR_SH_IS << TTBCR_SH0_SHIFT) |
 	      (TTBCR_RGN_WBWA << TTBCR_ORGN0_SHIFT) |
-	      (TTBCR_RGN_WBWA << TTBCR_IRGN0_SHIFT) |
-	      (TTBCR_SL0_LVL_1 << TTBCR_SL0_SHIFT);
+	      (TTBCR_RGN_WBWA << TTBCR_IRGN0_SHIFT);
+
+	if (!stage1)
+		reg |= (TTBCR_SL0_LVL_1 << TTBCR_SL0_SHIFT);
+
 	writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBCR);
 
 	/* MAIR0 (stage-1 only) */
-- 
2.1.0

  parent reply	other threads:[~2014-08-29 14:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 14:47 [PATCH 0/7] iommu/arm-smmu: fixes for 3.17 Will Deacon
     [not found] ` <1409323665-9605-1-git-send-email-will.deacon-5wv7dgnIgG8@public.gmane.org>
2014-08-29 14:47   ` [PATCH 1/7] iommu/arm-smmu: avoid calling request_irq in atomic context Will Deacon
2014-08-29 14:47   ` [PATCH 2/7] iommu/arm-smmu: Do not access non-existing S2CR registers Will Deacon
2014-08-29 14:47   ` [PATCH 3/7] iommu/arm-smmu: fix s2cr and smr teardown on device detach from domain Will Deacon
2014-08-29 14:47   ` Will Deacon [this message]
2014-08-29 14:47   ` [PATCH 5/7] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x Will Deacon
2014-08-29 14:47   ` [PATCH 6/7] iommu/arm-smmu: fix corner cases in address size calculations Will Deacon
2014-08-29 14:47   ` [PATCH 7/7] iommu/arm-smmu: remove pgtable_page_{c,d}tor() Will Deacon
2014-09-01 14:34   ` [PATCH 0/7] iommu/arm-smmu: fixes for 3.17 Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409323665-9605-5-git-send-email-will.deacon@arm.com \
    --to=will.deacon-5wv7dgnigg8@public.gmane.org \
    --cc=hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jroedel-l3A5Bk7waGM@public.gmane.org \
    --cc=vladimir.murzin-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.