All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Filippov <jcmvbkbc@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@redhat.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH] drm/vmwgfx: select FB when DRM_VMWGFX is selected
Date: Mon,  1 Sep 2014 03:07:47 +0400	[thread overview]
Message-ID: <1409526467-20944-1-git-send-email-jcmvbkbc@gmail.com> (raw)

Otherwise, if FB is not selected build fails at linking step:
  vmwgfx_fb.c:(.text+0x4098b): undefined reference to `register_framebuffer'
  vmwgfx_fb.c:(.text+0x409c0): undefined reference to `framebuffer_release'
  vmwgfx_fb.c:(.text+0x409f4): undefined reference to `unregister_framebuffer'
  vmwgfx_fb.c:(.text+0x40a0e): undefined reference to `framebuffer_release'

Patch ae6445ac7475ff05 drm/vmwgfx: depends on FB
added dependency on FB that was subsequently removed in patch
04381b987292256d drm: Move plane helpers into drm_kms_helper.ko

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 drivers/gpu/drm/vmwgfx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/Kconfig b/drivers/gpu/drm/vmwgfx/Kconfig
index 67720f7..4fba548 100644
--- a/drivers/gpu/drm/vmwgfx/Kconfig
+++ b/drivers/gpu/drm/vmwgfx/Kconfig
@@ -1,6 +1,7 @@
 config DRM_VMWGFX
 	tristate "DRM driver for VMware Virtual GPU"
 	depends on DRM && PCI
+	select FB
 	select FB_DEFERRED_IO
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
-- 
1.7.7.6

             reply	other threads:[~2014-08-31 23:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31 23:07 Max Filippov [this message]
2014-08-31 23:20 ` [PATCH] drm/vmwgfx: select FB when DRM_VMWGFX is selected Randy Dunlap
2014-09-01  0:07   ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409526467-20944-1-git-send-email-jcmvbkbc@gmail.com \
    --to=jcmvbkbc@gmail.com \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.