From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/4] ACPI / LPSS: drop clkdev_name member from lpss_device_desc
Date: Tue, 02 Sep 2014 13:42:55 +0300 [thread overview]
Message-ID: <1409654575.30155.72.camel@linux.intel.com> (raw)
In-Reply-To: <20140902103446.GA30021@xps8300>
On Tue, 2014-09-02 at 13:34 +0300, Heikki Krogerus wrote:
> On Tue, Sep 02, 2014 at 11:43:16AM +0300, Andy Shevchenko wrote:
> > On Tue, 2014-09-02 at 10:55 +0300, Heikki Krogerus wrote:
> > > It was used to provide the correct con_id for the dma
> > > driver, but it's not needed. Even if the driver requests a
> > > clock with the con_id, it still gets the correct clock. The
> >
> > Maybe with -> without?
>
> No. What I'm trying say is that even though the dma engine driver
> requests the clock like this:
>
> dw->clk = devm_clk_get(chip->dev, "hclk")
>
> i.e. _with_ the con_id "hclk", it will still get the correct
> reference because..
> > > device name is enough to match a single clock.
Fair enough.
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2014-09-02 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 7:55 [PATCH 0/4] ACPI / LPSS: clock improvements Heikki Krogerus
2014-09-02 7:55 ` [PATCH 1/4] ACPI / LPSS: introduce flags Heikki Krogerus
2014-09-02 8:45 ` Andy Shevchenko
2014-09-02 7:55 ` [PATCH 2/4] ACPI / LPSS: drop clkdev_name member from lpss_device_desc Heikki Krogerus
2014-09-02 8:43 ` Andy Shevchenko
2014-09-02 10:34 ` Heikki Krogerus
2014-09-02 10:42 ` Andy Shevchenko [this message]
2014-09-02 7:55 ` [PATCH 3/4] ACPI / LPSS: support for 133MHz I2C source clock on Baytrail Heikki Krogerus
2014-09-02 7:55 ` [PATCH 4/4] ACPI / LPSS: remove struct lpss_shared_clock Heikki Krogerus
2014-09-02 8:47 ` Andy Shevchenko
2014-09-02 10:46 ` [PATCH 0/4] ACPI / LPSS: clock improvements Mika Westerberg
2014-09-03 21:49 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409654575.30155.72.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.