From: Prashant Sreedharan <prashant@broadcom.com>
To: Ivan Vecera <ivecera@redhat.com>
Cc: <netdev@vger.kernel.org>, Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH net v2] tg3: prevent ifup/ifdown during PCI error recovery
Date: Tue, 2 Sep 2014 10:32:56 -0700 [thread overview]
Message-ID: <1409679176.16238.2.camel@prashant> (raw)
In-Reply-To: <1409574117-19435-1-git-send-email-ivecera@redhat.com>
On Mon, 2014-09-01 at 14:21 +0200, Ivan Vecera wrote:
> The patch fixes race conditions between PCI error recovery callbacks and
> potential ifup/ifdown.
>
> First, if ifup (tg3_open) is called between tg3_io_error_detected() and
> tg3_io_resume() then tp->timer is armed twice before expiry. Once during
> tg3_open() and again during tg3_io_resume(). This results in BUG
> at kernel/time/timer.c:945.
>
> Second, if ifdown (tg3_close) is called between tg3_io_error_detected()
> and tg3_io_resume() then tg3_napi_disable() is called twice without
> a tg3_napi_enable between. Once during tg3_io_error_detected() and again
> during tg3_close(). The tg3_io_resume() then hangs on rtnl_lock().
>
> v2: Added logging messages per Prashant's request
>
> Cc: Prashant Sreedharan <prashant@broadcom.com>
> Cc: Michael Chan <mchan@broadcom.com>
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Prashant Sreedharan <prashant@broadcom.com>
--
next prev parent reply other threads:[~2014-09-02 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 12:21 [PATCH net v2] tg3: prevent ifup/ifdown during PCI error recovery Ivan Vecera
2014-09-02 17:32 ` Prashant Sreedharan [this message]
2014-09-02 20:02 ` David Miller
2014-09-03 16:25 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409679176.16238.2.camel@prashant \
--to=prashant@broadcom.com \
--cc=ivecera@redhat.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.