From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v12 10/14] xsm/flask: avoid spurious error messages when mapping I/O-memory Date: Wed, 3 Sep 2014 12:30:27 +0100 Message-ID: <1409743827.22712.16.camel@citrix.com> References: <1409416189-16564-1-git-send-email-avanzini.arianna@gmail.com> <1409416189-16564-11-git-send-email-avanzini.arianna@gmail.com> <1409743327.22712.11.camel@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409743327.22712.11.camel@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini Cc: paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com, andrii.tseglytskyi@globallogic.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-09-03 at 12:22 +0100, Ian Campbell wrote: > On Sat, 2014-08-30 at 18:29 +0200, Arianna Avanzini wrote: > > Currently, FLASK only handles the memory_mapping hypercall for the > > x86 architecture. In case the architecture is ARM, an error message > > will be printed regardless of how XSM has been configured. This > > commit lets the memory_mapping case be handled also for architectures > > other than x86. > > > > Signed-off-by: Arianna Avanzini > > Reviewed-by: Julien Grall > > Cc: Dario Faggioli > > Cc: Paolo Valente > > Cc: Stefano Stabellini > > Acked-by: Ian Campbell Although since patches further down the series require a resend I'm also going to ask that you rephrase the commit message in terms of what it does "Handle XEN_DOMCTL_memory_mapping for all architectures" rather than its side effect (removing an error message). With some sort of change along those lines you may keep the acked by. Ian.