From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbaIDXN6 (ORCPT ); Thu, 4 Sep 2014 19:13:58 -0400 Received: from cpsmtpb-ews06.kpnxchange.com ([213.75.39.9]:65438 "EHLO cpsmtpb-ews06.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbaIDXN5 (ORCPT ); Thu, 4 Sep 2014 19:13:57 -0400 Message-ID: <1409872435.5546.135.camel@x220> Subject: Re: [GIT PULL] Staging driver patches for 3.15-rc1 From: Paul Bolle To: Greg KH Cc: Insop Song , "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "'insop.song@gmail.com'" Date: Fri, 05 Sep 2014 01:13:55 +0200 In-Reply-To: <20140402230837.GA24324@kroah.com> References: <20140401184817.GA21855@kroah.com> <1396427043.18431.20.camel@x220> <20140402200428.GE26966@kroah.com> <7731bd53be4b49e2924a7002f74dc090@BY2PR07MB011.namprd07.prod.outlook.com> <20140402230837.GA24324@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-3.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 04 Sep 2014 23:13:55.0277 (UTC) FILETIME=[E613BFD0:01CFC895] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-04-02 at 16:08 -0700, Greg KH wrote: > On Wed, Apr 02, 2014 at 08:52:18PM +0000, Insop Song wrote: > > On Wed, April 02, 2014 1:04 PM, Greg KH wrote: > > > On Wed, Apr 02, 2014 at 10:24:03AM +0200, Paul Bolle wrote: > > > > On Tue, 2014-04-01 at 11:48 -0700, Greg KH wrote: > > > > > Staging driver pull request for 3.15-rc1 > > > > > > > > > > Here's the huge drivers/staging/ update for 3.15-rc1. > > > > > > > > > > Loads of cleanup fixes, a few drivers removed, and some new ones > > > added. > > > > > > > > > > All have been in linux-next for a while. > > > > > > > > > >[...] > > > > > > > > > > Insop Song (1): > > > > > staging: fpgaboot: Xilinx FPGA firmware download driver > > > > > > > > This commit adds checks for CONFIG_B4860G100. Is a patch to add a > > > > Kconfig symbol B4860G100 perhaps queued somewhere? > > > > > > Insop, I thought this config option was coming from some other place, right? > > > > > > > Paul, > > I didn't include CONFIG_B4860G100 in Kconfig in original patch set, > > since programming FPGA method can vary in different system, and this > > was discussed during the review with Greg as well. > > > > However, actual fpga programming method is well contained in io.c with > > ifdef-ed CONFIG_B4860G100, now I think I might better to update > > Kconfig to include CONFIG_B4860G100. > > > > Greg, what do you think? Any harm to add custom board CONFIG* to > > staging Kconfig? Let me know. > > Let's see what it would look like and we can go from there. Nothing appears to have changed: there are still checks for CONFIG_B4860G100 in next-20140904. Should I submit the trivial patch to remove those checks and the code they hide? Paul Bolle