From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2MyAzLzRdIGdwaW86IHN5c2NvbjogcmV1c2UgZm9yIGtl?= =?UTF-8?B?eXN0b25lIDIgc29jcw==?= Date: Fri, 05 Sep 2014 12:40:19 +0400 Message-ID: <1409906419.21574740@f322.i.mail.ru> References: <1409763935-5713-1-git-send-email-grygorii.strashko@ti.com> <1409763935-5713-4-git-send-email-grygorii.strashko@ti.com> Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 Return-path: Received: from fallback1.mail.ru ([94.100.181.184]:57368 "EHLO fallback1.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbaIEIkx (ORCPT ); Fri, 5 Sep 2014 04:40:53 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: =?UTF-8?B?TGludXMgV2FsbGVpag==?= Cc: =?UTF-8?B?ZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc=?= , =?UTF-8?B?QWxleGFuZHJlIENvdXJib3Q=?= , =?UTF-8?B?bGludXgtZ3Bpb0B2Z2VyLmtlcm5lbC5vcmc=?= , =?UTF-8?B?U2FudG9zaCBTaGlsaW1rYXI=?= , =?UTF-8?B?bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn?= , =?UTF-8?B?R3J5Z29yaWkgU3RyYXNoa28=?= , =?UTF-8?B?Um9iIEhlcnJpbmc=?= RnJpLCA1IFNlcCAyMDE0IDEwOjMwOjIwICswMjAwINC+0YIgTGludXMgV2FsbGVpaiA8bGludXMu d2FsbGVpakBsaW5hcm8ub3JnPjoKPiBPbiBXZWQsIFNlcCAzLCAyMDE0IGF0IDc6MDUgUE0sIEdy eWdvcmlpIFN0cmFzaGtvCj4gPGdyeWdvcmlpLnN0cmFzaGtvQHRpLmNvbT4gd3JvdGU6Cj4gCj4g PiBPbiBLZXlzdG9uZSBTT0NzLCBBUk0gaG9zdCBjYW4gc2VuZCBpbnRlcnJ1cHRzIHRvIERTUCBj b3JlcyB1c2luZyB0aGUKPiA+IERTUCBHUElPIGNvbnRyb2xsZXIgSVAuIEVhY2ggRFNQIEdQSU8g Y29udHJvbGxlciBwcm92aWRlcyAyOCBJUlEgc2lnbmFscyBmb3IKPiA+IGVhY2ggRFNQIGNvcmUu IFRoaXMgaXMgb25lIG9mIHRoZSBjb21wb25lbnQgdXNlZCBieSB0aGUgSVBDIG1lY2hhbmlzbSB1 c2VkCj4gPiBvbiBLZXlzdG9uZSBTT0NzLgo+ID4KPiA+IEtleXN0b25lIDIgRFNQIEdQSU8gY29u dHJvbGxlciBoYXMgc3BlY2lmaWMgZmVhdHVyZXM6Cj4gPiAtIGVhY2ggR1BJTyBjYW4gYmUgY29u ZmlndXJlZCBvbmx5IGFzIG91dHB1dCBwaW47Cj4gPiAtIHNldHRpbmcgR1BJTyB2YWx1ZSB0byAx IGNhdXNlcyBJUlEgZ2VuZXJhdGlvbiBvbiB0YXJnZXQgRFNQIGNvcmU7Cj4gPiAtIHJlYWRpbmcg cGluIHZhbHVlIHJldHVybnMgMCAtIGlmIElSUSB3YXMgaGFuZGxlZCBvciAxIC0gSVJRIGlzIHN0 aWxsCj4gPiAgIHBlbmRpbmcuCj4gPgo+ID4gVGhpcyBwYXRjaCB1cGRhdGVzIGdwaW8tc3lzY29u IGRyaXZlciB0byBiZSByZXVzZWQgYnkgS2V5c3RvbmUgMiBTb0NzLAo+ID4gYmVjYXVzZSB0aGUg S2V5c3RvbmUgMiBEU1AgR1BJTyBjb250cm9sbGVyIGlzIGNvbnRyb2xsZWQgdGhyb3VnaCBTeXNj b24KPiA+IGRldmljZXMgYW5kLCBhcyByZXF1ZXN0ZWQgYnkgTGludXMgV2FsbGVpaiwgc3VjaCBr aW5kIG9mIEdQSU8gY29udHJvbGxlcnMKPiA+IHNob3VsZCBiZSBpbnRlZ3JhdGVkIHdpdGggZHJp dmVycy9ncGlvL2dwaW8tc3lzY29uLmMgZHJpdmVyLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEdy eWdvcmlpIFN0cmFzaGtvIDxncnlnb3JpaS5zdHJhc2hrb0B0aS5jb20+Cj4gPiAtLS0KPiA+ICAu Li4vZGV2aWNldHJlZS9iaW5kaW5ncy9ncGlvL2dwaW8tZHNwLWtleXN0b25lLnR4dCB8IDM5ICsr KysrKysrKysrKysrKysrKysrKysKPiAKPiBSb2IsIGNhbiB5b3UgbG9vayBhdCB0aGVzZSBiaW5k aW5ncz8KPiAKPiBJIHN1c3BlY3QgdGhleSBtYXkgZmFsbCB1bmRlciB5b3VyIGNhdGVnb3J5IG9m ICJub3QgYSByZWFsIGRldmljZSwgYnV0Cj4gbGVha2luZyBMaW51eCBpbXBsZW1lbnRhdGlvbiBp bnRlcm5hbHMiLgoKVGhpcyBpcyB0aGUgcmVhc29uIHdoeSBJIHN1Z2dlc3RlZCB0byBtb3ZlIHRo ZSBvZmZzZXRzIGluIHRoZSBkcml2ZXIuCgotLS0KCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: shc_work@mail.ru (=?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?=) Date: Fri, 05 Sep 2014 12:40:19 +0400 Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2MyAzLzRdIGdwaW86IHN5c2NvbjogcmV1c2UgZm9yIGtl?= =?UTF-8?B?eXN0b25lIDIgc29jcw==?= In-Reply-To: References: <1409763935-5713-1-git-send-email-grygorii.strashko@ti.com> <1409763935-5713-4-git-send-email-grygorii.strashko@ti.com> Message-ID: <1409906419.21574740@f322.i.mail.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Fri, 5 Sep 2014 10:30:20 +0200 ?? Linus Walleij : > On Wed, Sep 3, 2014 at 7:05 PM, Grygorii Strashko > wrote: > > > On Keystone SOCs, ARM host can send interrupts to DSP cores using the > > DSP GPIO controller IP. Each DSP GPIO controller provides 28 IRQ signals for > > each DSP core. This is one of the component used by the IPC mechanism used > > on Keystone SOCs. > > > > Keystone 2 DSP GPIO controller has specific features: > > - each GPIO can be configured only as output pin; > > - setting GPIO value to 1 causes IRQ generation on target DSP core; > > - reading pin value returns 0 - if IRQ was handled or 1 - IRQ is still > > pending. > > > > This patch updates gpio-syscon driver to be reused by Keystone 2 SoCs, > > because the Keystone 2 DSP GPIO controller is controlled through Syscon > > devices and, as requested by Linus Walleij, such kind of GPIO controllers > > should be integrated with drivers/gpio/gpio-syscon.c driver. > > > > Signed-off-by: Grygorii Strashko > > --- > > .../devicetree/bindings/gpio/gpio-dsp-keystone.txt | 39 ++++++++++++++++++++++ > > Rob, can you look at these bindings? > > I suspect they may fall under your category of "not a real device, but > leaking Linux implementation internals". This is the reason why I suggested to move the offsets in the driver. ---