From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v1 3/4] libxl: add rt scheduler Date: Fri, 5 Sep 2014 11:19:15 +0200 Message-ID: <1409908755.2673.243.camel@Solace.lan> References: <1408921125-21470-1-git-send-email-mengxu@cis.upenn.edu> <1408921125-21470-4-git-send-email-mengxu@cis.upenn.edu> <54087C75.8090907@eu.citrix.com> <1409845492.2673.240.camel@Solace.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8441218297701714600==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: Ian Campbell , Sisu Xi , Stefano Stabellini , George Dunlap , Chenyang Lu , Ian Jackson , Ian Jackson , "xen-devel@lists.xen.org" , Linh Thi Xuan Phan , Meng Xu , Jan Beulich , Chao Wang , Chong Li , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============8441218297701714600== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EsdpVtosfIwbKiSHVkNb" --=-EsdpVtosfIwbKiSHVkNb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2014-09-04 at 12:12 -0400, Meng Xu wrote: > 2014-09-04 11:55 GMT-04:00 George Dunlap=20 > =20 > >> I see. I'm totally ok with the decision! :-) > >> So I will only use the existing libxl interface without > adding an > >> array to it, to set/get the vcpus' parameters of a domain. > Am I right? > >> > > Yep, no array. You just add a 'period' and a 'budget' fields > _inside_ > > libxl_domain_sched_params, without putting them inside any > wrapping > > struct, union or array. > =20 > =20 > Except that you don't need to add a "period" field, since > there's > already one there (for the SEDF scheduler). > =20 Right, I overlooked that, sorry. :-P > We could re-use the "slice" field instead of adding "budget", > but I > think probably for clarity adding "budget" is better (although > I'm > open to other opinions on that one). >=20 >=20 > =E2=80=8BI like the idea of adding "budget" because it's much clearer. = =E2=80=8B >=20 I'm fine with adding a "budget" parameter too. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-EsdpVtosfIwbKiSHVkNb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQJgBMACgkQk4XaBE3IOsTDqgCfQIBJw1xZogYtyyPiyw7+uh70 c7YAnjQ2ovPp3EvyeajPu0b1K1GjvEd1 =AXmm -----END PGP SIGNATURE----- --=-EsdpVtosfIwbKiSHVkNb-- --===============8441218297701714600== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8441218297701714600==--