From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v1 2/4] libxc: add rt scheduler Date: Fri, 5 Sep 2014 19:50:53 +0200 Message-ID: <1409939453.16667.17.camel@Solace.lan> References: <1408921125-21470-1-git-send-email-mengxu@cis.upenn.edu> <1408921125-21470-3-git-send-email-mengxu@cis.upenn.edu> <1409913264.2673.298.camel@Solace.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5593392827998677877==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: Ian Campbell , Sisu Xi , Stefano Stabellini , George Dunlap , Ian Jackson , "xen-devel@lists.xen.org" , Meng Xu , Jan Beulich , Chao Wang , Chong Li , Dagaen Golomb List-Id: xen-devel@lists.xenproject.org --===============5593392827998677877== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-eNLPd6ZCkbDFx432BkwO" --=-eNLPd6ZCkbDFx432BkwO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2014-09-05 at 13:17 -0400, Meng Xu wrote: > 2014-09-05 6:34 GMT-04:00 Dario Faggioli : > > So, for instance, this file can continue being xc_rt.c, but this > > function needs to be called xc_sched_rtds_domain_set() > > (or .._rt_ds_domain_..) >=20 > As to the function name, if I change it to ..._rt_ds_domain_... in > xc_rt.c file, do I need to change it in libxl and xl files? In > addition, do I need to change the name rt_* functions in > xen/common/sched_rt.c in the hypervisor? This seems a lot of (well > easy) change, but we need some consensus to avoid changing it back > later. :-P > I see your point, and I'm actually not so sure... Would appreciate George's and others' view here. IIRC, we decided for RT_DS for two reasons: * make it more clear what kind of real-time scheduler this is, among all the existing real-time schedulers * make it possible to add more and different RT_xxx schedulers without having to rename this one and/or cause confusion I think both these arguments are valid for whatever component of the Xen architecture we are dealing with. We decided to keep the filename sched_rt.c (and xc_rt.c, etc), because it is at least quite likely that these other real-time scheduling policies, if ever implemented, could all live there. About the function names, I would apply the same approach. Most of them, I think they should be named after the scheduler they deal with. Some of them may be general enough to just be called bla_rt_foo(), but it's really hard to judge now. However, since this also is about interfaces, I'd really appreciate seeing what others think. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-eNLPd6ZCkbDFx432BkwO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQJ9/0ACgkQk4XaBE3IOsQ+tACfe0uN7eeC+rgiJRm1sog4nwIR UT4An2KcnCSI8/QD1qfmqTf0F13UBMBG =HiRM -----END PGP SIGNATURE----- --=-eNLPd6ZCkbDFx432BkwO-- --===============5593392827998677877== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5593392827998677877==--