From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Carlos Rafael Giani <dv@pseudoterminal.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel.bbclass: handle .dsp firmware
Date: Mon, 08 Sep 2014 12:18:21 +0100 [thread overview]
Message-ID: <1410175101.19272.1.camel@ted> (raw)
In-Reply-To: <1410174256-3263-1-git-send-email-dv@pseudoterminal.org>
On Mon, 2014-09-08 at 13:04 +0200, Carlos Rafael Giani wrote:
> A few firmware files use this filename extension, like korg/k1212.dsp .
> Create respective packages.
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
> meta/classes/kernel.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index b02036f..4710719 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -387,6 +387,7 @@ python split_kernel_packages () {
> do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> + do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> }
Perhaps its time to improve the regex slightly here and use something
like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to
do_split_packages?
Cheers,
Richard
next prev parent reply other threads:[~2014-09-08 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 11:04 [PATCH] kernel.bbclass: handle .dsp firmware Carlos Rafael Giani
2014-09-08 11:18 ` Richard Purdie [this message]
2014-09-08 12:08 ` Carlos Rafael Giani
2014-09-08 12:54 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410175101.19272.1.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dv@pseudoterminal.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.