From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 2/4] libxc: add rt scheduler Date: Mon, 8 Sep 2014 16:53:34 +0200 Message-ID: <1410188014.4005.96.camel@Solace.lan> References: <1410118861-2671-1-git-send-email-mengxu@cis.upenn.edu> <1410118861-2671-3-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2186955989774108160==" Return-path: In-Reply-To: <1410118861-2671-3-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============2186955989774108160== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-7ZHoPWL7x1HwoNngJ4b1" --=-7ZHoPWL7x1HwoNngJ4b1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On dom, 2014-09-07 at 15:40 -0400, Meng Xu wrote: > Add xc_sched_rt_* functions to interact with Xen to set/get domain's > parameters for rt scheduler. > Note: VCPU's information (period, budget) is in microsecond (us). >=20 > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi This looks fine. With the scheduler name properly updated (as George is saying, and as pointed out below): Reviewed-by: Dario Faggioli > diff --git a/tools/libxc/xc_rt.c b/tools/libxc/xc_rt.c > new file mode 100644 > index 0000000..e62f745 > --- /dev/null > +++ b/tools/libxc/xc_rt.c > @@ -0,0 +1,65 @@ > +/***********************************************************************= ***** > + * > + * File: xc_rt.c > + * Author: Sisu Xi=20 > + * Meng Xu > + * > + * Description: XC Interface to the rt scheduler > + * Note: VCPU's parameter (period, budget) is in microsecond (us). > + * All VCPUs of the same domain have same period and budget. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; > + * version 2.1 of the License. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-= 1301 USA > + */ > + > +#include "xc_private.h" > + > +int xc_sched_rt_domain_set(xc_interface *xch, > + uint32_t domid, > + struct xen_domctl_sched_rt *sdom) xen_domctl_sched_rtds > +{ > + int rc; > + DECLARE_DOMCTL; > + > + domctl.cmd =3D XEN_DOMCTL_scheduler_op; > + domctl.domain =3D (domid_t) domid; > + domctl.u.scheduler_op.sched_id =3D XEN_SCHEDULER_RT_DS; RTDS > + domctl.u.scheduler_op.cmd =3D XEN_DOMCTL_SCHEDOP_putinfo; > + domctl.u.scheduler_op.u.rt.period =3D sdom->period; rtds > + domctl.u.scheduler_op.u.rt.budget =3D sdom->budget; rtds > + > + rc =3D do_domctl(xch, &domctl); > + > + return rc; > +} > + > +int xc_sched_rt_domain_get(xc_interface *xch, > + uint32_t domid, > + struct xen_domctl_sched_rt *sdom) rtds > +{ > + int rc; > + DECLARE_DOMCTL; > + > + domctl.cmd =3D XEN_DOMCTL_scheduler_op; > + domctl.domain =3D (domid_t) domid; > + domctl.u.scheduler_op.sched_id =3D XEN_SCHEDULER_RT_DS; RTDS > + domctl.u.scheduler_op.cmd =3D XEN_DOMCTL_SCHEDOP_getinfo; > + > + rc =3D do_domctl(xch, &domctl); > + > + if ( rc =3D=3D 0 ) > + *sdom =3D domctl.u.scheduler_op.u.rt; rtds > + > + return rc; > +} > Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-7ZHoPWL7x1HwoNngJ4b1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQNwu4ACgkQk4XaBE3IOsQOMwCeIz/mVDbCG0s0hpMVuMz0PFYG fGkAn0f2+tGBkTAgCZXQ1pxoQR8UGX6E =daCf -----END PGP SIGNATURE----- --=-7ZHoPWL7x1HwoNngJ4b1-- --===============2186955989774108160== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2186955989774108160==--