From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shevchenko, Andriy" Subject: Re: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Date: Tue, 9 Sep 2014 09:01:44 +0000 Message-ID: <1410253304.25129.6.camel@intel.com> References: <1409928798-31895-1-git-send-email-alvin.chen@intel.com> <4656BEB6164FC34F8171C6538F1A595B2E9829DA@SHSMSX101.ccr.corp.intel.com> <1409918522.30155.89.camel@intel.com> <31986364.cn091cmIXU@wuerfel> <4656BEB6164FC34F8171C6538F1A595B2E983296@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com ([192.55.52.93]:13196 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbaIIJDY (ORCPT ); Tue, 9 Sep 2014 05:03:24 -0400 In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E983296@SHSMSX101.ccr.corp.intel.com> Content-Language: en-US Content-ID: <8472BDCBB653DA4390AE67AADB58207B@intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "Chen, Alvin" Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Kweh, Hock Leong" , "sebastian@breakpoint.cc" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "gnurou@gmail.com" , "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "grant.likely@linaro.org" , "Westerberg, Mika" , "arnd@arndb.de" , "dvhart@linux.intel.com" , "atull@opensource.altera.com" T24gVHVlLCAyMDE0LTA5LTA5IGF0IDAxOjUwICswMDAwLCBDaGVuLCBBbHZpbiB3cm90ZToNCj4g PiBPbiBGcmlkYXkgMDUgU2VwdGVtYmVyIDIwMTQgMTI6MDI6MDEgU2hldmNoZW5rbywgQW5kcml5 IHdyb3RlOg0KPiA+ID4gPiBpcnEgPSBpcnFfb2ZfcGFyc2VfYW5kX21hcChub2RlLCAwKTsgSWYg KCFpcnEpIHsNCj4gPiA+ID4gcHAtPmlycSA9IC0xOw0KPiA+ID4gPiByZXR1cm47DQo+ID4gPiA+ IH0gZWxzZSB7DQo+ID4gPiA+IHBwLT5pcnEgPSBpcnE7DQo+ID4gPiA+IH0NCj4gPiA+ID4gVGhl biB0aGUgY29kZSBsb29rcyBzdHJhbmdlLg0KPiA+ID4gPg0KPiA+ID4gPiBIb3cgZG8geW91IHRo aW5rPw0KPiA+ID4NCj4gPiA+IElmIEkgdW5kZXJzdG9vZCBjb3JyZWN0bHkgeW91IG1lc3NlZCB1 cCB3aXRoIGh3aXJxIHZzLiB2aXJxLg0KPiA+ID4gT3RoZXJ3aXNlIHlvdSBoYXZlIG1lbnRpb24g dGhhdCB5b3UgYXJlIHVzaW5nIHZpcnEgZXZlcnl3aGVyZSAoSSBndWVzcw0KPiA+ID4geW91IG1h eSByZW5hbWUgdGhlIGZpZWxkIGluIHRoZSBzdHJ1Y3R1cmUpLCBidXQgaW4gdGhpcyBjYXNlIHRo ZSBmaWVsZA0KPiA+ID4gaW4gdGhlIHBsYXRmb3JtX2RhdGEgbG9va3MgYSBiaXQgc3RyYW5nZS4N Cj4gPiANCj4gPiBUaGUgZmllbGQgaW4gcGxhdGZvcm1fZGF0YSBzaG91bGQgYmUgdGhlIG1hcHBl ZCB2aXJ0dWFsIGlycSBudW1iZXIsIGl0IG1ha2VzIG5vDQo+ID4gc2Vuc2UgdG8gdXNlIHRoZSBo d2lycSB1bmxlc3MgeW91IGFsc28gYWRkIGEgcG9pbnRlciB0byB0aGUgZG9tYWluIGluIHdoaWNo DQo+ID4gdGhhdCBod2lycSBleGlzdHMuDQo+ID4gDQo+ID4gQWxzbyB0aGUgb3V0cHV0IG9mIGly cV9vZl9wYXJzZV9hbmRfbWFwKCkgaXMgYSBtYXBwZWQgaXJxLCBhcyB0aGUgbmFtZQ0KPiA+IHN1 Z2dlc3RzLg0KPiA+IA0KPiBJIGFncmVlIHdpdGggQXJuZC4gSGVyZSwgdGhlICdpcnEnIGlzICd2 aXJxJy4NCj4gQW5kcml5LCB5b3UgbWF5IGJlIGNvbmZ1c2VkIGJ5IHRoZSBjb2RlIGxpa2UgJ2ly cV9jcmVhdGVfbWFwcGluZycuIEZvciBRdWFyayBjYXNlLCBpdCBoYXMgOCBHUElPIHBpbnMsIGFu ZCBlYWNoIHBpbiBjYW4gdHJpZ2dlcg0KPiBpbnRlcnJ1cHQsIGJ1dCBhbGwgdGhlc2UgaW50ZXJy dXB0cyBhcmUgdHJpZ2dlcmVkIGJ5IFBDSSBpcnEgd2hpY2ggaXMgc2hhcmVkLiBUaGUgJ2lycScg aW4gcGRhdGEgaXMgUENJIGlycS4gQXMgYWxsIEdQSU8gaW50ZXJydXB0cyBjb25uZWN0IHRvIHRo ZSBQQ0kNCj4gaXJxLCBvbmNlIHRoZSBHUElPIGludGVycnVwdCBpcyB0cmlnZ2VyZWQsIGFuZCB0 aGUgUENJIGlycSBoYW5kbGVyIHdpbGwgYmUgY2FsbGVkICdkd2FwYl9pcnFfaGFuZGxlcl9tZmQn LiBBbmQgaW4gJ2R3YXBiX2RvX2lycScsIGl0IHdpbGwgcmVhZCB0aGUNCj4gaW50ZXJydXB0IHJl Z2lzdGVyIHRvIHNlZSB0aGUgaW50ZXJydXB0IGlzIHRyaWdnZXJlZCBieSB3aGljaCBHUElPIHBp biwgYW5kICdpcnFfY3JlYXRlX21hcHBpbmcnIGlzIGZvciB0aGlzIGNhc2UuDQoNClRoYW5rcyBm b3IgY2xhcmlmaWNhdGlvbi4gSSB0YWtlIGJhY2sgbXkgaW5pdGlhbCBjb21tZW50IHRoZW4uDQoN Ci0tIA0KQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BpbnRlbC5jb20+DQpJbnRl bCBGaW5sYW5kIE95DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW50ZWwgRmlubGFuZCBPeQpSZWdpc3RlcmVkIEFk ZHJlc3M6IFBMIDI4MSwgMDAxODEgSGVsc2lua2kgCkJ1c2luZXNzIElkZW50aXR5IENvZGU6IDAz NTc2MDYgLSA0IApEb21pY2lsZWQgaW4gSGVsc2lua2kgCgpUaGlzIGUtbWFpbCBhbmQgYW55IGF0 dGFjaG1lbnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRlcmlhbCBmb3IKdGhlIHNvbGUg dXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcgb3IgZGlzdHJpYnV0 aW9uCmJ5IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJZiB5b3UgYXJlIG5vdCB0aGUg aW50ZW5kZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVyIGFuZCBkZWxldGUg YWxsIGNvcGllcy4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756262AbaIIJD1 (ORCPT ); Tue, 9 Sep 2014 05:03:27 -0400 Received: from mga11.intel.com ([192.55.52.93]:13196 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbaIIJDY (ORCPT ); Tue, 9 Sep 2014 05:03:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,491,1406617200"; d="scan'208";a="588439588" From: "Shevchenko, Andriy" To: "Chen, Alvin" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Kweh, Hock Leong" , "sebastian@breakpoint.cc" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "gnurou@gmail.com" , "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "grant.likely@linaro.org" , "Westerberg, Mika" , "arnd@arndb.de" , "dvhart@linux.intel.com" , "atull@opensource.altera.com" Subject: Re: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Thread-Topic: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Thread-Index: AQHPyNc/kBMLSfD+Nk6gyOY6CiHQz5vyMzuAgAAX0oCAACslvIAFiEkAgAB4bgA= Date: Tue, 9 Sep 2014 09:01:44 +0000 Message-ID: <1410253304.25129.6.camel@intel.com> References: <1409928798-31895-1-git-send-email-alvin.chen@intel.com> <4656BEB6164FC34F8171C6538F1A595B2E9829DA@SHSMSX101.ccr.corp.intel.com> <1409918522.30155.89.camel@intel.com> <31986364.cn091cmIXU@wuerfel> <4656BEB6164FC34F8171C6538F1A595B2E983296@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <4656BEB6164FC34F8171C6538F1A595B2E983296@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.168] Content-Type: text/plain; charset="utf-8" Content-ID: <8472BDCBB653DA4390AE67AADB58207B@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8993VMC004683 On Tue, 2014-09-09 at 01:50 +0000, Chen, Alvin wrote: > > On Friday 05 September 2014 12:02:01 Shevchenko, Andriy wrote: > > > > irq = irq_of_parse_and_map(node, 0); If (!irq) { > > > > pp->irq = -1; > > > > return; > > > > } else { > > > > pp->irq = irq; > > > > } > > > > Then the code looks strange. > > > > > > > > How do you think? > > > > > > If I understood correctly you messed up with hwirq vs. virq. > > > Otherwise you have mention that you are using virq everywhere (I guess > > > you may rename the field in the structure), but in this case the field > > > in the platform_data looks a bit strange. > > > > The field in platform_data should be the mapped virtual irq number, it makes no > > sense to use the hwirq unless you also add a pointer to the domain in which > > that hwirq exists. > > > > Also the output of irq_of_parse_and_map() is a mapped irq, as the name > > suggests. > > > I agree with Arnd. Here, the 'irq' is 'virq'. > Andriy, you may be confused by the code like 'irq_create_mapping'. For Quark case, it has 8 GPIO pins, and each pin can trigger > interrupt, but all these interrupts are triggered by PCI irq which is shared. The 'irq' in pdata is PCI irq. As all GPIO interrupts connect to the PCI > irq, once the GPIO interrupt is triggered, and the PCI irq handler will be called 'dwapb_irq_handler_mfd'. And in 'dwapb_do_irq', it will read the > interrupt register to see the interrupt is triggered by which GPIO pin, and 'irq_create_mapping' is for this case. Thanks for clarification. I take back my initial comment then. -- Andy Shevchenko Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I