From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shevchenko, Andriy" Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Date: Thu, 11 Sep 2014 07:59:51 +0000 Message-ID: <1410422381.7023.15.camel@intel.com> References: <1410286081-16653-1-git-send-email-alvin.chen@intel.com> <1410286081-16653-2-git-send-email-alvin.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com ([192.55.52.93]:17085 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbaIKIAA (ORCPT ); Thu, 11 Sep 2014 04:00:00 -0400 In-Reply-To: Content-Language: en-US Content-ID: <02B140BC09EDAA45A1366FC6FDB253C7@intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "atull@opensource.altera.com" Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Chen, Alvin" , "Kweh, Hock Leong" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "gnurou@gmail.com" , "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "sebastian@breakpoint.cc" , "grant.likely@linaro.org" , "Westerberg, Mika" , "dvhart@linux.intel.com" , "arnd@arndb.de" T24gV2VkLCAyMDE0LTA5LTEwIGF0IDE0OjExIC0wNTAwLCBhdHVsbCB3cm90ZToNCg0KW10NCg0K PiA+ICBzdGF0aWMgaW50IGR3YXBiX2dwaW9fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikNCj4gPiAgew0KPiA+ICsJaW50IGk7DQo+ID4gIAlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsN Cj4gPiAgCXN0cnVjdCBkd2FwYl9ncGlvICpncGlvOw0KPiA+IC0Jc3RydWN0IGRldmljZV9ub2Rl ICpucDsNCj4gPiAgCWludCBlcnI7DQo+ID4gLQl1bnNpZ25lZCBpbnQgb2ZmcyA9IDA7DQo+ID4g KwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Ow0KPiA+ICsJc3RydWN0IGR3YXBiX3Bs YXRmb3JtX2RhdGEgKnBkYXRhID0gZGV2X2dldF9wbGF0ZGF0YShkZXYpOw0KPiA+ICsJYm9vbCBp c19wZGF0YV9hbGxvYyA9ICFwZGF0YTsNCj4gDQo+IFBsZWFzZSBjb21iaW5lIHRoZSBpbnQncyBp biBvbmUgbGluZSAoaW50IGVyciwgaTspIGFuZCBwdXQgdGhlbSBhcw0KPiB0aGUgbGFzdCBvbmUg b24gdGhpcyBsaXN0LiAgSXQgbG9va3MgdGhlIHNhbWUgdG8gdGhlIGNvbXBpbGVyIG9mDQo+IGNv dXJzZSwgYnV0IG1vcmUgdW5pZm9ybSBmb3IgaHVtYW4gZXllcyA6KQ0KDQpEbyB5b3UgdGhpbmsg aXQncyBhIGdvb2QgaWRlYT8gSW4gdGhpcyBjYXNlIEksIGZvciBleGFtcGxlLCB3b3VsZCBsaWtl DQp0byBzZWUgaW50IGVyciBhcyBhIHNlcGFyYXRlIGxpbmUgYXQgdGhlIGVuZCBvZiBkZWZpbml0 aW9uIGJsb2NrLiBJdA0Kd291bGQgYmUgYmV0dGVyIHRvIGRpc3Rpbmd1aXNoIGNvdW50ZXJzIGFu ZCByZXR1cm4gY29kZSBzdG9yYWdlLg0KTW9yZW92ZXIsIG9mdGVuIGNvdW50ZXJzIHdvdWxkIGJl IHVuc2lnbmVkIGludC4NCg0KLS0gDQpBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtv QGludGVsLmNvbT4NCkludGVsIEZpbmxhbmQgT3kNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJbnRlbCBGaW5sYW5k IE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5raSAKQnVzaW5lc3Mg SWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxzaW5raSAKClRoaXMg ZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIG1hdGVy aWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4gQW55IHJl dmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0ZWQuIElm IHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0IHRoZSBz ZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbaIKIAD (ORCPT ); Thu, 11 Sep 2014 04:00:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:17085 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbaIKIAA (ORCPT ); Thu, 11 Sep 2014 04:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,504,1406617200"; d="scan'208";a="589712675" From: "Shevchenko, Andriy" To: "atull@opensource.altera.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Chen, Alvin" , "Kweh, Hock Leong" , "devicetree@vger.kernel.org" , "Ong, Boon Leong" , "gnurou@gmail.com" , "linus.walleij@linaro.org" , "linux-gpio@vger.kernel.org" , "sebastian@breakpoint.cc" , "grant.likely@linaro.org" , "Westerberg, Mika" , "dvhart@linux.intel.com" , "arnd@arndb.de" Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Thread-Topic: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver Thread-Index: AQHPzBcrxlSNNsy4REqDrhjV17xohJv6rQ6AgADWroA= Date: Thu, 11 Sep 2014 07:59:51 +0000 Message-ID: <1410422381.7023.15.camel@intel.com> References: <1410286081-16653-1-git-send-email-alvin.chen@intel.com> <1410286081-16653-2-git-send-email-alvin.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.168] Content-Type: text/plain; charset="utf-8" Content-ID: <02B140BC09EDAA45A1366FC6FDB253C7@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8B809fo021757 On Wed, 2014-09-10 at 14:11 -0500, atull wrote: [] > > static int dwapb_gpio_probe(struct platform_device *pdev) > > { > > + int i; > > struct resource *res; > > struct dwapb_gpio *gpio; > > - struct device_node *np; > > int err; > > - unsigned int offs = 0; > > + struct device *dev = &pdev->dev; > > + struct dwapb_platform_data *pdata = dev_get_platdata(dev); > > + bool is_pdata_alloc = !pdata; > > Please combine the int's in one line (int err, i;) and put them as > the last one on this list. It looks the same to the compiler of > course, but more uniform for human eyes :) Do you think it's a good idea? In this case I, for example, would like to see int err as a separate line at the end of definition block. It would be better to distinguish counters and return code storage. Moreover, often counters would be unsigned int. -- Andy Shevchenko Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I