From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-doc@vger.kernel.org, linux-pm@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v4 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM
Date: Tue, 16 Sep 2014 11:34:55 +0200 [thread overview]
Message-ID: <1410860095.16106.1.camel@AMDC1943> (raw)
In-Reply-To: <20140916092006.GG12361@n2100.arm.linux.org.uk>
On wto, 2014-09-16 at 10:20 +0100, Russell King - ARM Linux wrote:
> On Tue, Sep 16, 2014 at 10:51:33AM +0200, Krzysztof Kozlowski wrote:
> > @@ -191,8 +210,11 @@ static int amba_probe(struct device *dev)
> > pm_runtime_enable(dev);
> >
> > ret = pcdrv->probe(pcdev, id);
> > - if (ret == 0)
> > + if (ret == 0) {
> > + if (pm_runtime_is_irq_safe(dev))
> > + pcdev->irq_safe = 1;
>
> Patch looks good, though I'd prefer this to always explicitly initialise
> pcdev->irq_safe each time a probe succeeds.
No problem, I'll add this and resend.
Thank you for feedback,
Krzysztof
next prev parent reply other threads:[~2014-09-16 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 8:51 [PATCH v4 0/4] amba/dma: pl330: add Power Management support Krzysztof Kozlowski
2014-09-16 8:51 ` [PATCH v4 1/4] PM / Runtime: Add getter for quering the IRQ safe option Krzysztof Kozlowski
2014-09-16 8:51 ` [PATCH v4 2/4] amba: Add helper macros for (un)preparing AMBA clock Krzysztof Kozlowski
2014-09-16 8:51 ` [PATCH v4 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Krzysztof Kozlowski
2014-09-16 9:20 ` Russell King - ARM Linux
2014-09-16 9:34 ` Krzysztof Kozlowski [this message]
2014-09-16 8:51 ` [PATCH v4 4/4] dma: pl330: add Power Management support Krzysztof Kozlowski
2014-09-17 18:42 ` Ulf Hansson
2014-09-18 10:09 ` Krzysztof Kozlowski
2014-09-23 15:39 ` Ulf Hansson
2014-09-24 10:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410860095.16106.1.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=michal.simek@xilinx.com \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.