From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.5 v2 2/2] xen: arm: Enable physical
 address space compression (PDX) on arm32
Date: Tue, 16 Sep 2014 20:33:50 +0100
Message-ID: <1410896030.23505.34.camel@citrix.com>
References: <1410534866.27902.12.camel@kazak.uk.xensource.com>
	<1410534923-17209-2-git-send-email-ian.campbell@citrix.com>
	<54137B04.6080907@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54137B04.6080907@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Roy Franz <roy.franz@linaro.org>, stefano.stabellini@eu.citrix.com, tim@xen.org, Fu Wei <fu.wei@linaro.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-09-12 at 16:00 -0700, Julien Grall wrote:
> > +/* Sets all bits from the most-significant 1-bit down to the LSB */
> > +static u64 __init fill_mask(u64 mask)
> > +{
> > +    while (mask & (mask + 1))
> > +        mask |= mask + 1;
> > +    return mask;
> > +}
> 
> The function is the same on x86. Shall we create an helper?

I'll see what I can do.

> > diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
> > index 1c3abcf..59b2887 100644
> > --- a/xen/include/asm-arm/config.h
> > +++ b/xen/include/asm-arm/config.h
> > @@ -126,7 +126,12 @@
> >   #define CONFIG_SEPARATE_XENHEAP 1
> >
> >   #define FRAMETABLE_VIRT_START  _AT(vaddr_t,0x02000000)
> > -#define VMAP_VIRT_START  _AT(vaddr_t,0x10000000)
> > +#define FRAMETABLE_SIZE        MB(128-32)
> 
> I would add a comment about why the frametable size is "MB(128-32)".

There is a big comment just above here which gives an overview of the
virtual address space layout. I don't think it needs repeating here.

Ian.