From: Jan Stancek <jstancek@redhat.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: vasily isaenko <vasily.isaenko@oracle.com>,
ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v4] fw_load: new test of device firmware loading
Date: Thu, 20 Jun 2013 09:29:29 -0400 (EDT) [thread overview]
Message-ID: <1411057592.110807.1371734969213.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1371731503-13164-1-git-send-email-alexey.kodanev@oracle.com>
----- Original Message -----
> From: "Alexey Kodanev" <alexey.kodanev@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "vasily isaenko" <vasily.isaenko@oracle.com>, "Alexey Kodanev" <alexey.kodanev@oracle.com>
> Sent: Thursday, 20 June, 2013 2:31:43 PM
> Subject: [LTP] [PATCH v4] fw_load: new test of device firmware loading
>
> This test checks the device firmware loading. Since Linux 3.7 it can be
> loaded
> directly (by-pass udev). The test consists of the two parts: userspace and
> kernelspace.
>
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Hi,
looks good to me. I ran it with 3.10-rc4 and 2.6.18 kernel, worked as expected.
This included:
[PATCH v3] configure: add configure checks to compile kernel modules
[PATCH] tst_module: create new library functions for kernel modules
[PATCH v4] fw_load: new test of device firmware loading
I have one small suggestion, likely not worthy of making v5 just for this.
We could apply it on top later:
--- testcases/kernel/firmware/fw_load_kernel/Makefile 2013-06-20 15:08:19.339046672 +0200
+++ /tmp/Makefile 2013-06-20 15:11:50.876602284 +0200
@@ -18,7 +18,9 @@
ifneq ($(KERNELRELEASE),)
+ifdef CONFIG_FW_LOADER
obj-m := $(MODULE).o
+endif
else
@@ -26,7 +28,7 @@
include $(top_srcdir)/include/mk/env_pre.mk
MAKE_TARGETS := $(MODULE).ko
-$(MODULE).ko:
+$(MODULE).ko: fw_load.c
-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
-mv $(MODULE).ko $(MODULE).ko~
-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
Regards,
Jan
> ---
> runtest/syscalls | 2 +
> testcases/kernel/Makefile | 1 +
> testcases/kernel/firmware/Makefile | 44 ++++
> .../kernel/firmware/fw_load_kernel/.gitignore | 1 +
> testcases/kernel/firmware/fw_load_kernel/Makefile | 37 ++++
> testcases/kernel/firmware/fw_load_kernel/README | 16 ++
> testcases/kernel/firmware/fw_load_kernel/fw_load.c | 173 +++++++++++++++
> testcases/kernel/firmware/fw_load_user/.gitignore | 1 +
> testcases/kernel/firmware/fw_load_user/Makefile | 20 ++
> testcases/kernel/firmware/fw_load_user/README | 11 +
> testcases/kernel/firmware/fw_load_user/fw_load.c | 219
> ++++++++++++++++++++
> 11 files changed, 525 insertions(+), 0 deletions(-)
> create mode 100644 testcases/kernel/firmware/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/.gitignore
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/README
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/fw_load.c
> create mode 100644 testcases/kernel/firmware/fw_load_user/.gitignore
> create mode 100644 testcases/kernel/firmware/fw_load_user/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_user/README
> create mode 100644 testcases/kernel/firmware/fw_load_user/fw_load.c
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-06-20 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 12:31 [LTP] [PATCH v4] fw_load: new test of device firmware loading Alexey Kodanev
2013-06-20 13:29 ` Jan Stancek [this message]
2013-06-20 14:38 ` alexey.kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411057592.110807.1371734969213.JavaMail.root@redhat.com \
--to=jstancek@redhat.com \
--cc=alexey.kodanev@oracle.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.