From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Fri, 19 Sep 2014 09:50:37 +0300 [thread overview]
Message-ID: <1411109437.3997.9.camel@iivanov-dev> (raw)
In-Reply-To: <alpine.DEB.2.01.1409182041040.30983@pmeerw.net>
On Thu, 2014-09-18 at 20:59 +0200, Peter Meerwald wrote:
<snip>
> I'd prefix with SPMI_IADC_
Is this really necessary? I could prefix it with IADC3, which
is the subtype of this peripheral.
> > +#define IADC_REVISION2 0x1
> > +#define IADC_REVISION2_SUPPORTED_IADC 1
> > +
> > +#define IADC_PERPH_TYPE 0x4
> > +#define IADC_PERPH_TYPE_ADC 8
> > +
> > +#define IADC_PERPH_SUBTYPE 0x5
> > +#define IADC_PERPH_SUBTYPE_IADC 3
Rest of the comments will be fixed in next version.
Thank you for review.
Regards,
Ivan
next prev parent reply other threads:[~2014-09-19 6:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 13:15 [PATCH] iio: iadc: Qualcomm SPMI PMIC current ADC driver Ivan T. Ivanov
2014-09-18 13:15 ` Ivan T. Ivanov
2014-09-18 18:59 ` Peter Meerwald
2014-09-19 6:50 ` Ivan T. Ivanov [this message]
2014-09-19 8:27 ` Peter Meerwald
2014-09-21 13:32 ` Jonathan Cameron
2014-09-19 10:19 ` Kiran Padwal
[not found] ` <541C032F.3080206-edOiRQu9Xnj5XLMNweQjbQ@public.gmane.org>
2014-09-19 12:16 ` Ivan T. Ivanov
2014-09-19 12:16 ` Ivan T. Ivanov
2014-09-21 14:04 ` Jonathan Cameron
2014-09-23 8:31 ` Ivan T. Ivanov
2014-09-27 10:06 ` Jonathan Cameron
2014-09-27 10:06 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411109437.3997.9.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.