From: Scott Chacon <schacon@gmail.com>
To: git@vger.kernel.org
Cc: Scott Chacon <schacon@gmail.com>
Subject: [PATCH] notes: accept any ref for merge
Date: Fri, 19 Sep 2014 09:39:45 +0200 [thread overview]
Message-ID: <1411112385-33479-1-git-send-email-schacon@gmail.com> (raw)
Currently if you try to merge notes, the notes code ensures that the
reference is under the 'refs/notes' namespace. In order to do any sort
of collaborative workflow, this doesn't work well as you can't easily
have local notes refs seperate from remote notes refs.
This patch changes the expand_notes_ref function to check for simply a
leading refs/ instead of refs/notes to check if we're being passed an
expanded notes reference. This would allow us to set up
refs/remotes-notes or otherwise keep mergeable notes references outside
of what would be contained in the notes push refspec.
Signed-off-by: Scott Chacon <schacon@gmail.com>
---
notes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/notes.c b/notes.c
index 5fe691d..78d58af 100644
--- a/notes.c
+++ b/notes.c
@@ -1293,7 +1293,7 @@ int copy_note(struct notes_tree *t,
void expand_notes_ref(struct strbuf *sb)
{
- if (starts_with(sb->buf, "refs/notes/"))
+ if (starts_with(sb->buf, "refs/"))
return; /* we're happy */
else if (starts_with(sb->buf, "notes/"))
strbuf_insert(sb, 0, "refs/", 5);
--
2.0.0
next reply other threads:[~2014-09-19 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 7:39 Scott Chacon [this message]
2014-09-19 9:39 ` [PATCH] notes: accept any ref for merge Jeff King
2014-09-19 14:01 ` Johan Herland
2014-09-19 18:22 ` Junio C Hamano
2014-09-20 0:01 ` Johan Herland
2014-09-22 17:34 ` Junio C Hamano
2014-11-22 18:04 ` Kyle J. McKay
2014-12-04 10:26 ` Jeff King
2014-09-19 17:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411112385-33479-1-git-send-email-schacon@gmail.com \
--to=schacon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.