From: Namhyung Kim <namhyung@kernel.org>
To: Milian Wolff <mail@milianw.de>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Joseph Schuchart <joseph.schuchart@tu-dresden.de>
Subject: Re: Perf event for Wall-time based sampling?
Date: Sat, 20 Sep 2014 00:50:57 +0900 [thread overview]
Message-ID: <1411141857.1680.23.camel@leonhard> (raw)
In-Reply-To: <38149799.gZAnD74qWP@milian-kdab2>
2014-09-19 (금), 16:53 +0200, Milian Wolff:
> On Friday 19 September 2014 11:33:40 Arnaldo Carvalho de Melo wrote:
> > Em Fri, Sep 19, 2014 at 02:59:55PM +0900, Namhyung Kim escreveu:
> > > Hi Arnaldo and Millan,
> > >
> > > On Thu, 18 Sep 2014 16:17:13 -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Thu, Sep 18, 2014 at 06:37:47PM +0200, Milian Wolff escreveu:
> > > >> That would indeed be very welcome. There are multiple "defaults" in
> > > >> perf which I find highly confusing. The --no-children above e.g.
> > > >> could/should probably be the default, no? Similar, I find it extremely
> > > >> irritating that `perf report -g`> >
> > > > It was, this is something we've actually been discussing recently: the
> > > > change that made --children be the default mode. That is why I added
> > > > Namhyung and Ingo to the CC list, so that they become aware of more
> > > > reaction to this change.
> > >
> > > Yeah, we should rethink about changing the default now. Actually I'm
> > > okay with the change, Ingo what do you think?
> > >
> > > >> defaults to `-g fractal` and not `-g graph`.
> > > >>
> > > >> 100% foo
> > > >>
> > > >> 70% bar
> > > >>
> > > >> 70% asdf
> > > >> 30% lalala
> > > >>
> > > >> 30% baz
> > > >>
> > > >> is much harder to interpret than
> > > >>
> > > >> 100% foo
> > > >>
> > > >> 70% bar
> > > >>
> > > >> 49% asdf
> > > >> 21% lalala
> > > >>
> > > >> 30% baz
> > >
> > > I also agree with you. :)
> > >
> > > > But the question then is if this is configurable, if not that would be a
> > > > first step, i.e. making this possible via some ~/.perfconfig change.
> > >
> > > Yes, we have record.call-graph and top.call-graph config options now so
> > > adding a new report.call-graph option should not be difficult. However
> > > I think it'd be better being call-graph.XXX as it can be applied to all
> >
> > No problem, with sourcing being supported in ~/.perfconfig, we can have
> > as many #include call-graph.XXX as needed, multiple levels of includes
> > and all.
> >
> > > other subcommands transparently.
> > >
> > > What about like below?
> > >
> > > [call-graph]
> > >
> > > mode = dwarf
> > > dump-size = 8192
> > > print-type = fractal
> > > order = callee
> > > threshold = 0.5
> > > print-limit = 128
> > > sort-key = function
> >
> > Milian, does this provide what you expect? How would we call this
> > specific call-graph profile?
>
> print-type should be graph, not fractal. Otherwise it sounds good to me. But
> how would one use it? I tried putting it into ~/.perfconfig, but apparently my
> 3.16.2-1-ARCH Perf does not support this feature yet? How/when would that
> config be used? As soon as one does "perf record -g" (for mode and dump-size)
> or "perf report" (for a perf.data with call graphs)? That would be very
> useful!
This is a proposal for new config items which can be included into the
~/.perfconfig file. You can change it as you want later and it should
apply to default behavior of perf record -g and perf report.
Thanks,
Namhyung
next prev parent reply other threads:[~2014-09-19 15:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 12:32 Perf event for Wall-time based sampling? Milian Wolff
2014-09-18 13:23 ` Arnaldo Carvalho de Melo
2014-09-18 13:41 ` Milian Wolff
2014-09-18 14:51 ` Arnaldo Carvalho de Melo
2014-09-18 15:26 ` Milian Wolff
2014-09-18 15:57 ` Arnaldo Carvalho de Melo
2014-09-18 16:37 ` Milian Wolff
2014-09-18 19:17 ` Arnaldo Carvalho de Melo
2014-09-18 19:31 ` Arnaldo Carvalho de Melo
2014-09-18 20:17 ` David Ahern
2014-09-18 20:36 ` Arnaldo Carvalho de Melo
2014-09-18 20:39 ` David Ahern
2014-09-19 8:11 ` Milian Wolff
2014-09-19 9:08 ` Milian Wolff
2014-09-19 14:47 ` Arnaldo Carvalho de Melo
2014-09-19 15:04 ` David Ahern
2014-09-19 15:05 ` Milian Wolff
2014-09-19 14:17 ` David Ahern
2014-09-19 14:39 ` Milian Wolff
2014-09-19 14:55 ` David Ahern
2014-09-19 5:59 ` Namhyung Kim
2014-09-19 14:33 ` Arnaldo Carvalho de Melo
2014-09-19 14:53 ` Milian Wolff
2014-09-19 15:50 ` Namhyung Kim [this message]
2014-09-22 7:56 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411141857.1680.23.camel@leonhard \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=joseph.schuchart@tu-dresden.de \
--cc=linux-perf-users@vger.kernel.org \
--cc=mail@milianw.de \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.