From: Paul Bolle <pebolle@tiscali.nl>
To: Richard Kuo <rkuo@codeaurora.org>
Cc: linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Hexagon: Remove useless select of NO_IOPORT_MAP
Date: Wed, 24 Sep 2014 21:21:51 +0200 [thread overview]
Message-ID: <1411586511.19525.38.camel@x220> (raw)
Hexagon's primary Kconfig entry has a select for NO_IOPORT_MAP. But
because hexagon never defines a Kconfig symbol NO_IOPORT_MAP this select
is a nop. It can be removed.
Perhaps hexagon should add its own Kconfig entry for NO_IOPORT_MAP and
have it default to 'y'. But since no one apparently had any problems
with HAS_IOPORT_MAP defaulting to 'y' on hexagon, as it currently does,
that is unlikely.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested by playing with arch/hexagon/configs/comet_defconfig. After "make
oldconfig" the .config contains CONFIG_HAS_IOPORT_MAP=y both before and
after this patch, as is expected.
Actually, the only difference I found in the .config file was that after
this patch the .config file contained
CONFIG_HEXAGON=y
I have no idea why. Did I botch my test?
arch/hexagon/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
index 4dc89d1f9c48..f1817eae107a 100644
--- a/arch/hexagon/Kconfig
+++ b/arch/hexagon/Kconfig
@@ -19,7 +19,6 @@ config HEXAGON
select GENERIC_IRQ_SHOW
select HAVE_ARCH_KGDB
select HAVE_ARCH_TRACEHOOK
- select NO_IOPORT_MAP
select GENERIC_IOMAP
select GENERIC_SMP_IDLE_THREAD
select STACKTRACE_SUPPORT
--
1.9.3
next reply other threads:[~2014-09-24 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 19:21 Paul Bolle [this message]
2014-09-25 10:11 ` [PATCH] Hexagon: Remove useless select of NO_IOPORT_MAP Paul Bolle
2014-09-30 1:25 ` rkuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411586511.19525.38.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.