From: Sjoerd Simons <sjoerd-FGvqe4uplSY@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [5/5] ARM: tegra: jetson-tk1: enable GK20A GPU
Date: Thu, 25 Sep 2014 20:10:31 +0200 [thread overview]
Message-ID: <1411668631.24948.9.camel@luon.net> (raw)
In-Reply-To: <20140925164109.GA30382@ulmo>
On Thu, 2014-09-25 at 18:41 +0200, Thierry Reding wrote:
> On Thu, Sep 25, 2014 at 09:48:01AM -0600, Stephen Warren wrote:
> > On 09/25/2014 07:27 AM, Sjoerd Simons wrote:
> > >Playing a bit with todays linux-next on my jetson, it seems this patch is
> > >still required for enabling the GPU. Is there anything blocking it (firmware
> > >not available yet in liux-firmware?)
> >
> > I think initially I was waiting for the DRM patch "drm/nouvea: support for
> > probing platform devices" to be applied, but it looks like that's been
> > applied already, so only patches 4 and 5 in this series are still
> > outstanding.
> >
> > Alex, wasn't there also some issue where the VPR register had to be
> > programmed, and if it wasn't there'd be a hang when the GPU registers were
> > touched? If we've added code to Nouveau/tegradrm to detect that and avoid
> > the problem, then I guess we can commit these last two patches for 3.19. A
> > resend after the 3.18 merge window might help.
>
> A patch that programs VPR was merged into U-Boot (though I don't think
> it's made it into master yet).
Assuming you're talking about "ARM: tegra: Disable VPR",that has landed
in u-boot master and released as part of v2014.10-rc2 [0]
> I'm not sure we can reasonably check for
> that in Nouveau, given that the register is somewhere completely
> unrelated. In fact I think the U-Boot patch was triggered by some
> discussion about how to solve this and it was decided that it shouldn't
> be done in the kernel, but U-Boot should set it up.
>
> That said, perhaps one solution would be to make U-Boot enable the gk20a
> device if it's set up the VPR and disable it otherwise?
I guess in that case the vdd-supply should still be added to the dts
with u-boot toggling the status field of the node?
0: http://git.denx.de/?p=u-boot.git;a=commit;h=df3443dfa449ad02bef8ddf6e2c90a6fd9394fc9
--
Sjoerd Simons <sjoerd-FGvqe4uplSY@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sjoerd Simons <sjoerd@luon.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
gnurou@gmail.com
Subject: Re: [5/5] ARM: tegra: jetson-tk1: enable GK20A GPU
Date: Thu, 25 Sep 2014 20:10:31 +0200 [thread overview]
Message-ID: <1411668631.24948.9.camel@luon.net> (raw)
In-Reply-To: <20140925164109.GA30382@ulmo>
On Thu, 2014-09-25 at 18:41 +0200, Thierry Reding wrote:
> On Thu, Sep 25, 2014 at 09:48:01AM -0600, Stephen Warren wrote:
> > On 09/25/2014 07:27 AM, Sjoerd Simons wrote:
> > >Playing a bit with todays linux-next on my jetson, it seems this patch is
> > >still required for enabling the GPU. Is there anything blocking it (firmware
> > >not available yet in liux-firmware?)
> >
> > I think initially I was waiting for the DRM patch "drm/nouvea: support for
> > probing platform devices" to be applied, but it looks like that's been
> > applied already, so only patches 4 and 5 in this series are still
> > outstanding.
> >
> > Alex, wasn't there also some issue where the VPR register had to be
> > programmed, and if it wasn't there'd be a hang when the GPU registers were
> > touched? If we've added code to Nouveau/tegradrm to detect that and avoid
> > the problem, then I guess we can commit these last two patches for 3.19. A
> > resend after the 3.18 merge window might help.
>
> A patch that programs VPR was merged into U-Boot (though I don't think
> it's made it into master yet).
Assuming you're talking about "ARM: tegra: Disable VPR",that has landed
in u-boot master and released as part of v2014.10-rc2 [0]
> I'm not sure we can reasonably check for
> that in Nouveau, given that the register is somewhere completely
> unrelated. In fact I think the U-Boot patch was triggered by some
> discussion about how to solve this and it was decided that it shouldn't
> be done in the kernel, but U-Boot should set it up.
>
> That said, perhaps one solution would be to make U-Boot enable the gk20a
> device if it's set up the VPR and disable it otherwise?
I guess in that case the vdd-supply should still be added to the dts
with u-boot toggling the status field of the node?
0: http://git.denx.de/?p=u-boot.git;a=commit;h=df3443dfa449ad02bef8ddf6e2c90a6fd9394fc9
--
Sjoerd Simons <sjoerd@luon.net>
next prev parent reply other threads:[~2014-09-25 18:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 9:24 [PATCH 0/5] drm/nouveau: platform devices and GK20A probing Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
[not found] ` <1400491450-19223-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-19 9:24 ` [PATCH 1/5] drm/nouveau: support for probing platform devices Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
2014-05-19 9:24 ` [PATCH 3/5] ARM: tegra: add GK20A GPU to Tegra124 DT Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
2014-05-19 21:16 ` Stephen Warren
2014-05-19 21:16 ` Stephen Warren
2014-05-19 9:24 ` [PATCH 4/5] ARM: tegra: venice2: enable GK20A GPU Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
2014-05-19 9:24 ` [PATCH 5/5] ARM: tegra: jetson-tk1: " Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
[not found] ` <1400491450-19223-6-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-09-25 13:27 ` [5/5] " Sjoerd Simons
2014-09-25 13:27 ` Sjoerd Simons
2014-09-25 15:48 ` Stephen Warren
2014-09-25 16:41 ` Thierry Reding
2014-09-25 16:41 ` Thierry Reding
2014-09-25 18:07 ` Stephen Warren
2014-09-25 18:07 ` Stephen Warren
[not found] ` <542459C5.9060505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-26 9:59 ` Thierry Reding
2014-09-26 9:59 ` Thierry Reding
2014-09-25 18:10 ` Sjoerd Simons [this message]
2014-09-25 18:10 ` Sjoerd Simons
2014-09-26 10:01 ` Thierry Reding
2014-09-26 10:01 ` Thierry Reding
[not found] ` <54243931.6050804-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-09-26 4:44 ` Alexandre Courbot
2014-09-26 4:44 ` Alexandre Courbot
2014-05-19 9:24 ` [PATCH 2/5] ARM: tegra: of: add GK20A device tree binding Alexandre Courbot
2014-05-19 9:24 ` Alexandre Courbot
2014-05-19 21:14 ` Stephen Warren
2014-05-19 21:14 ` Stephen Warren
[not found] ` <537A7450.5030904-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-23 7:13 ` Alexandre Courbot
2014-05-23 7:13 ` Alexandre Courbot
2014-05-19 10:04 ` [PATCH 0/5] drm/nouveau: platform devices and GK20A probing Lucas Stach
2014-05-19 10:04 ` Lucas Stach
[not found] ` <1400493868.8467.26.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2014-05-19 10:06 ` Thierry Reding
2014-05-19 10:06 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411668631.24948.9.camel@luon.net \
--to=sjoerd-fgvqe4uplsy@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.