All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Sukholitko <boriss@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] virtio-9p: Remove migration blockers.
Date: Fri, 26 Sep 2014 18:19:57 +0300	[thread overview]
Message-ID: <1411744797-17121-3-git-send-email-boriss@gmail.com> (raw)
In-Reply-To: <1411744797-17121-1-git-send-email-boriss@gmail.com>

Signed-off-by: Boris Sukholitko <boriss@gmail.com>
---
 hw/9pfs/virtio-9p.c | 24 ------------------------
 hw/9pfs/virtio-9p.h |  2 --
 2 files changed, 26 deletions(-)

diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 5861a5b..2bf3c0a 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -332,19 +332,6 @@ static int put_fid(V9fsPDU *pdu, V9fsFidState *fidp)
      * Don't free the fid if it is in reclaim list
      */
     if (!fidp->ref && fidp->clunked) {
-        if (fidp->fid == pdu->s->root_fid) {
-            /*
-             * if the clunked fid is root fid then we
-             * have unmounted the fs on the client side.
-             * delete the migration blocker. Ideally, this
-             * should be hooked to transport close notification
-             */
-            if (pdu->s->migration_blocker) {
-                migrate_del_blocker(pdu->s->migration_blocker);
-                error_free(pdu->s->migration_blocker);
-                pdu->s->migration_blocker = NULL;
-            }
-        }
         return free_fid(pdu, fidp);
     }
     return 0;
@@ -979,17 +966,6 @@ static void v9fs_attach(void *opaque)
     err += offset;
     trace_v9fs_attach_return(pdu->tag, pdu->id,
                              qid.type, qid.version, qid.path);
-    /*
-     * disable migration if we haven't done already.
-     * attach could get called multiple times for the same export.
-     */
-    if (!s->migration_blocker) {
-        s->root_fid = fid;
-        error_setg(&s->migration_blocker,
-                   "Migration is disabled when VirtFS export path '%s' is mounted in the guest using mount_tag '%s'",
-                   s->ctx.fs_root ? s->ctx.fs_root : "NULL", s->tag);
-        migrate_add_blocker(s->migration_blocker);
-    }
 out:
     put_fid(pdu, fidp);
 out_nofid:
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index 2c3603a..23f8eba 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -222,8 +222,6 @@ typedef struct V9fsState
      * on rename.
      */
     CoRwlock rename_lock;
-    int32_t root_fid;
-    Error *migration_blocker;
     V9fsConf fsconf;
 } V9fsState;
 
-- 
2.0.2

  parent reply	other threads:[~2014-09-26 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 15:19 [Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset Boris Sukholitko
2014-09-26 15:19 ` [Qemu-devel] [PATCH 1/2] virtio-9p: Add support for 9p migration Boris Sukholitko
2014-09-29 21:48   ` Benoît Canet
2014-09-30 19:13     ` Boris Sukholitko
2014-09-26 15:19 ` Boris Sukholitko [this message]
2014-09-29 21:46 ` [Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset Benoît Canet
2014-09-30 19:08   ` Boris Sukholitko
2014-09-30 19:17     ` Benoît Canet
2014-10-01  6:43       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411744797-17121-3-git-send-email-boriss@gmail.com \
    --to=boriss@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.