From: khilman@kernel.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sched/nohz: add debugfs control over sched_tick_max_deferment
Date: Fri, 26 Sep 2014 12:45:32 -0700 [thread overview]
Message-ID: <1411760732-14102-1-git-send-email-khilman@kernel.org> (raw)
From: Kevin Hilman <khilman@linaro.org>
Allow debugfs override of sched_tick_max_deferment in order to ease
finding/fixing the remaining issues with full nohz.
The value to be written is in jiffies, and -1 means the max deferment
is disabled (scheduler_tick_max_deferment() returns KTIME_MAX.)
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
kernel/sched/core.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index bc1638b33449..dee044a5d447 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2514,6 +2514,8 @@ void scheduler_tick(void)
}
#ifdef CONFIG_NO_HZ_FULL
+static u32 sched_tick_max_deferment = HZ;
+
/**
* scheduler_tick_max_deferment
*
@@ -2532,13 +2534,25 @@ u64 scheduler_tick_max_deferment(void)
struct rq *rq = this_rq();
unsigned long next, now = ACCESS_ONCE(jiffies);
- next = rq->last_sched_tick + HZ;
+ if (sched_tick_max_deferment == -1)
+ return KTIME_MAX;
+
+ next = rq->last_sched_tick + sched_tick_max_deferment;
if (time_before_eq(next, now))
return 0;
return jiffies_to_nsecs(next - now);
}
+
+static __init int sched_nohz_full_init_debug(void)
+{
+ debugfs_create_u32("sched_tick_max_deferment", 0644, NULL,
+ &sched_tick_max_deferment);
+
+ return 0;
+}
+late_initcall(sched_nohz_full_init_debug);
#endif
notrace unsigned long get_parent_ip(unsigned long addr)
--
2.1.0
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, Kevin Hilman <khilman@linaro.org>
Subject: [PATCH] sched/nohz: add debugfs control over sched_tick_max_deferment
Date: Fri, 26 Sep 2014 12:45:32 -0700 [thread overview]
Message-ID: <1411760732-14102-1-git-send-email-khilman@kernel.org> (raw)
From: Kevin Hilman <khilman@linaro.org>
Allow debugfs override of sched_tick_max_deferment in order to ease
finding/fixing the remaining issues with full nohz.
The value to be written is in jiffies, and -1 means the max deferment
is disabled (scheduler_tick_max_deferment() returns KTIME_MAX.)
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Kevin Hilman <khilman@linaro.org>
---
kernel/sched/core.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index bc1638b33449..dee044a5d447 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2514,6 +2514,8 @@ void scheduler_tick(void)
}
#ifdef CONFIG_NO_HZ_FULL
+static u32 sched_tick_max_deferment = HZ;
+
/**
* scheduler_tick_max_deferment
*
@@ -2532,13 +2534,25 @@ u64 scheduler_tick_max_deferment(void)
struct rq *rq = this_rq();
unsigned long next, now = ACCESS_ONCE(jiffies);
- next = rq->last_sched_tick + HZ;
+ if (sched_tick_max_deferment == -1)
+ return KTIME_MAX;
+
+ next = rq->last_sched_tick + sched_tick_max_deferment;
if (time_before_eq(next, now))
return 0;
return jiffies_to_nsecs(next - now);
}
+
+static __init int sched_nohz_full_init_debug(void)
+{
+ debugfs_create_u32("sched_tick_max_deferment", 0644, NULL,
+ &sched_tick_max_deferment);
+
+ return 0;
+}
+late_initcall(sched_nohz_full_init_debug);
#endif
notrace unsigned long get_parent_ip(unsigned long addr)
--
2.1.0
next reply other threads:[~2014-09-26 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 19:45 Kevin Hilman [this message]
2014-09-26 19:45 ` [PATCH] sched/nohz: add debugfs control over sched_tick_max_deferment Kevin Hilman
2014-09-26 20:03 ` Kevin Hilman
2014-09-26 20:03 ` Kevin Hilman
2014-09-27 16:59 ` Frederic Weisbecker
2014-09-27 16:59 ` Frederic Weisbecker
2014-09-29 15:11 ` Kevin Hilman
2014-09-29 15:11 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411760732-14102-1-git-send-email-khilman@kernel.org \
--to=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.